Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation update #2206

Merged
merged 3 commits into from
Jan 24, 2017
Merged

French translation update #2206

merged 3 commits into from
Jan 24, 2017

Conversation

trebmuh
Copy link
Contributor

@trebmuh trebmuh commented Jan 24, 2017

Hope that helps.

msgid "%(used-size)s used, %(free-size)s available"
msgstr "<b>%s</b> utilisé(s), <b>%s</b> disponible(s)"
msgstr "%(taille-utilisée)s utilisé(es), %(taille-libre)s disponible(s)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text in %(...)s should not be translated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint. Corrected. I'm pushing the fix in a few minutes.

@lazka
Copy link
Member

lazka commented Jan 24, 2017

Thanks!

msgid "Show \"All Albums\" Item"
msgstr "Tous les albums"
msgstr "Monter tous les éléments \"Tous les albums\""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Monter" -> "Montrer"

I need to have a look at this message in its context, but it does sound weird like that. The message in English does not talk about multiple items, so I would go with "Montrer l'élément "Tous les albums"", but…

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint. Fixed. I'm pushing the fix in a few minutes.

msgid "Album Collection Preferences"
msgstr "Préférences de l'affichage liste d'albums"
msgstr "Préférences de la collection d'album"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write "albums", as "collection de" or "liste de" will always be followed by a plural.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Fixed. I'm pushing the fix in a few minutes.

msgid "Downloading station list"
msgstr "Télécharger les fichiers"
msgstr "Télécharger la liste de station"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"[…] liste des stations"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one since the EN version is not in a plural form. I think you're point of view make sense even if both are fine (referring to the "quantity" or to the "quality" are both fine in French, and I guesstimate that it's the same in English here). If we'd go to changing to plural, it would first need a fix in the original EN version first since I don't like moving out the original when translating.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think English is different though here - we use singular forms for the first noun in compound nouns typically (car parks, boat races, meeting notes etc)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"stations' list" could have been used as well, isn't ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trebmuh - People would work out what it meant, but it'd never be written like that idiomatically.

Copy link
Contributor Author

@trebmuh trebmuh Jan 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, strange, I've been seeing that written a numerous times when I was working in a council during 3 years in Australia.

Anyway, fix pushed.

msgid "Confirm action for playlist \"%s\""
msgstr "Confirmez la suppression de la liste de lecture"
msgstr "Confirmez l'action pour liste de lecture\"%s\""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a space missing between "lecture" and ""%s"". I would also add a "la": "[…] l'action pour la liste de […]"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eyes. Thanks for the hints. Fixed. I'm pushing this in a few seconds.

@trebmuh
Copy link
Contributor Author

trebmuh commented Jan 24, 2017

@pierremoreau and @lazka : I've pushed the fixes in regards of your comments. Thanks for your help.

@trebmuh
Copy link
Contributor Author

trebmuh commented Jan 24, 2017

Last fix pushed.

@pierremoreau
Copy link

@trebmuh Thank you for your work!

@lazka lazka merged commit 0b4390b into quodlibet:master Jan 24, 2017
@lazka
Copy link
Member

lazka commented Jan 24, 2017

Thanks!

lazka added a commit that referenced this pull request Jan 24, 2017
@trebmuh
Copy link
Contributor Author

trebmuh commented Jan 24, 2017

All good, thanks for the quick push and the help people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants