Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upplugin: add a plugin to toggle the menubar's visibility #2263
Conversation
ptitjes
force-pushed the
ptitjes:togglemenubar
branch
from
13d1404
to
72f4e8a
Feb 23, 2017
This comment has been minimized.
This comment has been minimized.
|
Hmm, more relevantly though: this behaviour already works without the plugin for me (Ubuntu 16.10, GTK 3.20.9). Is this an OS X only problem? |
This comment has been minimized.
This comment has been minimized.
|
I could not tell because I don't use OS X. I run my Mac on Fedora 25, and I don't have the menu bar toggle... Hence my plugin :) Is this only on Ubuntu ? Can you see it on other GTK applications ? |
| window = app.window | ||
| # Maybe this should be made directly accessible | ||
| menubar = window.get_children()[0].get_children()[0] |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is only the case for Ubuntu + Unity with their patched gtk. |
lazka
merged commit 5a0d8ae
into
quodlibet:master
Feb 24, 2017
1 check passed
ptitjes
deleted the
ptitjes:togglemenubar
branch
Feb 24, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
|
A possible enhancement would be to listen to click events if shown and see if they are not on the menu or any submenu and then hide the menu again. that would more closely follow what for example firefox does. But I'm not sure how hard that is to implement. |
This comment has been minimized.
This comment has been minimized.
|
Oh yes indeed. I never did pay attention firefox/atom did that... |
ptitjes commentedFeb 23, 2017
By pressing the Alt key you can toggle the menubar's visibility (ala Firefox, Atom, ...)