Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: add a plugin to toggle the menubar's visibility #2263

Merged
merged 1 commit into from Feb 24, 2017

Conversation

@ptitjes
Copy link
Collaborator

@ptitjes ptitjes commented Feb 23, 2017

By pressing the Alt key you can toggle the menubar's visibility (ala Firefox, Atom, ...)

@ptitjes ptitjes force-pushed the ptitjes:togglemenubar branch from 13d1404 to 72f4e8a Feb 23, 2017
@declension
Copy link
Member

@declension declension commented Feb 24, 2017

Hmm, more relevantly though: this behaviour already works without the plugin for me (Ubuntu 16.10, GTK 3.20.9).

Is this an OS X only problem?

@ptitjes
Copy link
Collaborator Author

@ptitjes ptitjes commented Feb 24, 2017

I could not tell because I don't use OS X. I run my Mac on Fedora 25, and I don't have the menu bar toggle... Hence my plugin :) Is this only on Ubuntu ? Can you see it on other GTK applications ?

window = app.window

# Maybe this should be made directly accessible
menubar = window.get_children()[0].get_children()[0]

This comment has been minimized.

@lazka

lazka Feb 24, 2017
Member

Good enough for a one time thing I guess.

@lazka
Copy link
Member

@lazka lazka commented Feb 24, 2017

Hmm, more relevantly though: this behaviour already works without the plugin for me (Ubuntu 16.10, GTK 3.20.9).

This is only the case for Ubuntu + Unity with their patched gtk.

@lazka lazka merged commit 5a0d8ae into quodlibet:master Feb 24, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ptitjes ptitjes deleted the ptitjes:togglemenubar branch Feb 24, 2017
@ptitjes
Copy link
Collaborator Author

@ptitjes ptitjes commented Feb 24, 2017

Thanks!

@lazka
Copy link
Member

@lazka lazka commented Feb 24, 2017

A possible enhancement would be to listen to click events if shown and see if they are not on the menu or any submenu and then hide the menu again. that would more closely follow what for example firefox does. But I'm not sure how hard that is to implement.

@ptitjes
Copy link
Collaborator Author

@ptitjes ptitjes commented Feb 24, 2017

Oh yes indeed. I never did pay attention firefox/atom did that...
I'll think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants