plugin: add a tap bpm plugin

[ptitjes]

This is a very little plugin that allows the user to tap the BPM for the selected song and save it in its tags.

[lazka]

'clicked' event, otherwise pressing space/enter wont do anything if the button is focused.

[ptitjes]

I used press event because when you tap with a mouse or a pad, whereas the clicked comes at the release of the mouse/pad button. The user (well me) expects to tap at press. It is really not nice when tap is triggered by release, because not only you have to tap in rhythm but also kinda press the button for the same duration every time (not simple, I tried :p).

Maybe I should document it so that not one wonders in the future.

I could add an additional trigger for key-presses when the button is focused...

[lazka]

I see, let's leave it that way then for now..

[lazka]

add a translators comment above:

# TRANSLATORS: BPM measn "beats per minute"

[ptitjes]

Sure !

[lazka]

Why the idle_add?

[ptitjes]

It won't work without it, I think because we are in modal dialog.

[lazka]

What doesn't work? It seems to work the same here as far as I can see.

[ptitjes]

If call do_update directly in update, the label is never updated.

[ptitjes]

OK, forget it you're right ! :)
I'll change that.

[lazka]

Not a bug, but try to save before destroying the window. After destroy() widgets shouldn't be used anymore and while it currently doesn't use it in save(), it might in the future.

[ptitjes]

Indeed, I'll modify that !

[ptitjes]

@lazka Changes made as requested. I kept using "button-press-event" but added code to handle space/return key presses.

[lazka]

Thanks

[ptitjes]

Thank you !