Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaygain: save selected replaygain profiles to config (take 2) #2279

Merged
merged 2 commits into from Mar 3, 2017

Conversation

ptitjes
Copy link
Collaborator

@ptitjes ptitjes commented Feb 27, 2017

Fixes #2162.

Only the mode name is saved. Profile is set according to that name.

Replaces PR #2275.

Fixes quodlibet#2162.

Only the mode name is saved. Profile is set according to that name.
item.set_active(True)
item.show()

def __changed(self, item, player, profile):
def __set_mode(self, player, mode):
player.replaygain_profiles[0] = \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle unknown mode values. Crashing in this case makes it hard to extend them and switching between QL versions.

(In general, code should handle garbage config values in some "sane" way if possible)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rhaaa, of course !! Will fix that...

Fixes quodlibet#2162.

I chose to not modify the configuration (in case one uses a version
with additional modes) but rather just fallback to auto mode.
@ptitjes
Copy link
Collaborator Author

ptitjes commented Mar 2, 2017

@lazka Done. As stated in the commit message, I chose to not update the configuration but just fallback to the 'auto' mode. Tell me if that fits the bill !

@lazka lazka merged commit 155ba2c into quodlibet:master Mar 3, 2017
@lazka
Copy link
Member

lazka commented Mar 3, 2017

Thanks

@ptitjes ptitjes deleted the savedreplaygain2 branch March 3, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants