Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ubuntu 14.04 support Fixes #2288 #2290

Merged
merged 2 commits into from Mar 2, 2017

Conversation

lazka
Copy link
Member

@lazka lazka commented Mar 2, 2017

In case we drop Ubuntu 14.04 this is the oldest supported distro

In case we drop Ubuntu 14.04 this is the oldest supported distro

RUN pip install --upgrade pycodestyle pyflakes xvfbwrapper

RUN useradd -ms /bin/bash user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a general question: why are we adding a new user in all the Dockerfiles? I'd have thought we can run as root (like most containers do unless they really need to)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests failed which used chmod to make a file read only. I thought that since non-root is the usual execution env it can't hurt. Is there any downside?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool I see - and no not really, other than extra noise in the Dockerfiles

@lazka lazka changed the title travis: test on debian jessie Drop Ubuntu 14.04 support Mar 2, 2017
@lazka lazka changed the title Drop Ubuntu 14.04 support Drop Ubuntu 14.04 support Fixes #2288 Mar 2, 2017
@lazka lazka merged commit 78814c8 into quodlibet:master Mar 2, 2017
@lazka lazka mentioned this pull request Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants