New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ubuntu 14.04 support Fixes #2288 #2290

Merged
merged 2 commits into from Mar 2, 2017

Conversation

Projects
None yet
2 participants
@lazka
Member

lazka commented Mar 2, 2017

In case we drop Ubuntu 14.04 this is the oldest supported distro

travis: test on debian jessie
In case we drop Ubuntu 14.04 this is the oldest supported distro

RUN pip install --upgrade pycodestyle pyflakes xvfbwrapper

RUN useradd -ms /bin/bash user

This comment has been minimized.

@declension

declension Mar 2, 2017

Member

More of a general question: why are we adding a new user in all the Dockerfiles? I'd have thought we can run as root (like most containers do unless they really need to)?

This comment has been minimized.

@lazka

lazka Mar 2, 2017

Member

Some tests failed which used chmod to make a file read only. I thought that since non-root is the usual execution env it can't hurt. Is there any downside?

This comment has been minimized.

@declension

declension Mar 2, 2017

Member

Cool I see - and no not really, other than extra noise in the Dockerfiles

@lazka lazka force-pushed the lazka:travis-debian-jessie branch from 2379bbd to 46d2f7f Mar 2, 2017

@lazka lazka changed the title from travis: test on debian jessie to Drop Ubuntu 14.04 support Mar 2, 2017

@lazka lazka changed the title from Drop Ubuntu 14.04 support to Drop Ubuntu 14.04 support Fixes #2288 Mar 2, 2017

@lazka lazka merged commit 78814c8 into quodlibet:master Mar 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lazka lazka referenced this pull request Mar 2, 2017

Closed

Drop Ubuntu 14.04 support #2288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment