plugins: add a plugin to export a playlist to a folder #2307
Conversation
|
@ptitjes I'll try to have a look tonight. (FYI this kind of feature (albeit a less pretty version) can often be achieved by the Custom Commands plugin) |
|
@declension Thx.
I see. I did not this Custom Commands feature. But indeed, I'm glad to be able to select the destination folder and change the pattern at export :) |
| pattern_label.set_xalign(0.0) | ||
| box.pack_start(pattern_label, True, True, 0) | ||
|
|
||
| self.pattern_entry = Gtk.Entry(text=pattern) |
There was a problem hiding this comment.
a qltk.UndoEntry is slightly nicer IMO, or even ValidatingEntry here.
There was a problem hiding this comment.
Looking at the PatternCompiler/PatternParser/PatternLexer trio, I fail to see where it can fail. They seem to be bullet-proof even with ill-written patterns. What would validate a ValidatingEntry then ?
There was a problem hiding this comment.
Yeah that logic has changed a lot now and is more resilient to user errors (i.e. assumes more things are just text now). Probably needs some rethought, but there are too many use cases in the wild now for significant changes without breaking lots of people's set ups.
Anyway I found you can usually break it with # pretty easily - <#foo>
| box.pack_start(destination_label, True, True, 0) | ||
|
|
||
| frame = Gtk.Frame() | ||
| self.directory_chooser = \ |
There was a problem hiding this comment.
FYI we generally try to avoid backslash continuations (some discussion on alternatives, though the PEP itself was rejected: https://www.python.org/dev/peps/pep-3125/)
| self.set_response_sensitive(Gtk.ResponseType.OK, has_directory) | ||
|
|
||
| pattern_text = self.pattern_entry.get_text() | ||
| has_pattern = pattern_text != "" |
There was a problem hiding this comment.
FYI it's generally considered more Pythonic to use has_pattern = bool(pattern_text), or in the negative case just not pattern_text (also deals with None, etc)
| class Config(object): | ||
| _config = PluginConfig(__name__) | ||
|
|
||
| DEFAULT_PATTERN = "<artist> - <title>" |
There was a problem hiding this comment.
I recommend perhaps using a tied tag "<artist~title>" as it works better if is either is missing (e.g. in Classical music 0004. - - Sonata K.380.flac")
...unless those filenames themselves needs parsing by something strict I guess, but this is probably not the default case...
| hbox.set_border_width(6) | ||
| label = Gtk.Label(label=_("Default filename pattern:")) | ||
| hbox.pack_start(label, False, True, 0) | ||
| entry = Gtk.Entry() |
There was a problem hiding this comment.
This one more so even perhaps (custom Entry)
* fix som python code and style patterns * use UndoEntry for pattern entry * set a better default filename pattern
|
Thanks |
|
Thank you. |
This is a rough cut.
Please review and comment as to make it better.