Rework parts of the file/folderchooser handling #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer GTK+ added an interface for opening the native file chooser on Windows so add a simple interface using the new/old interface depending on the gtk+ version. Replaces some simple filechooser usage which didn't need API not available on Windows. One thing removed was the "watch for new files" checkbox, which was a bit confusing anyway imo. Some places saved/restored the last visible directory for the file chooser. This replaces it with a global path saved in the config. TODO: The remaining, less simple file chooser cases need to be replaced with the chooser and an addition dialog for further actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer GTK+ added an interface for opening the native file chooser on
Windows so add a simple interface using the new/old interface depending
on the gtk+ version.
Replaces some simple filechooser usage which didn't need API not available
on Windows. One thing removed was the "watch for new files" checkbox, which
was a bit confusing anyway imo.
Some places saved/restored the last visible directory for the file chooser.
This replaces it with a global path saved in the config.
TODO: The remaining, less simple file chooser cases need to be replaced with
the chooser and an addition dialog for further actions.