New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework parts of the file/folderchooser handling #2324

Merged
merged 2 commits into from Mar 19, 2017

Conversation

Projects
None yet
1 participant
@lazka
Member

lazka commented Mar 17, 2017

Newer GTK+ added an interface for opening the native file chooser on
Windows so add a simple interface using the new/old interface depending
on the gtk+ version.

Replaces some simple filechooser usage which didn't need API not available
on Windows. One thing removed was the "watch for new files" checkbox, which
was a bit confusing anyway imo.

Some places saved/restored the last visible directory for the file chooser.
This replaces it with a global path saved in the config.

TODO: The remaining, less simple file chooser cases need to be replaced with
the chooser and an addition dialog for further actions.

lazka added some commits Mar 17, 2017

Rework parts of the file/folderchooser handling
Newer GTK+ added an interface for opening the native file chooser on
Windows so add a simple interface using the new/old interface depending
on the gtk+ version.

Replaces some simple filechooser usage which didn't need API not available
on Windows. One thing removed was the "watch for new files" checkbox, which
was a bit confusing anyway imo.

Some places saved/restored the last visible directory for the file chooser.
This replaces it with a global path saved in the config.

TODO: The remaining, less simple file chooser cases need to be replaced with
the chooser and an addition dialog for further actions.

@lazka lazka merged commit 2e01ed1 into quodlibet:master Mar 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment