New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox to stop player after queue is empty #2340

Merged
merged 4 commits into from Apr 12, 2017

Conversation

Projects
None yet
3 participants
@frestr
Member

frestr commented Mar 20, 2017

Fixes #43

Although the "Queue Only" plugin has this as a side effect, the effect of always adding songs to the queue may not be desired. This addition instead adds a checkbox - "Stop After Empty" - next to the "Random" checkbox that has no other side effects than stopping the player after the queue is empty, instead of continuing to play a song from the song pane.

frestr added some commits Mar 20, 2017

QueueExpander: Do not explicitly turn off the start_after switch
This is done automatically after each playing song anyway, and
fixes a problem where the switch would be turned off if the
queue was cleared and "Start After Empty" not enabled.
left.pack_start(rand_checkbox, False, True, 0)
stop_checkbox = ConfigCheckButton(
_("Stop After Empty"), "memory", "queue_stop_after_empty")

This comment has been minimized.

@declension

declension Apr 9, 2017

Member

I think Stop Once Empty reads a bit better than Stop After Empty

This comment has been minimized.

@frestr

frestr Apr 9, 2017

Member

I agree. I based it on "Stop After This Song" under Controls, but the wording makes more sense in that case.

@declension

This comment has been minimized.

Member

declension commented Apr 9, 2017

Looks reasonable in general, and works for me - thanks.

Part of me still thinks this can / should be solved as a play order plugin / configuration for the queue itself, but that's a much bigger piece so maybe best to get this in for now.

@frestr

This comment has been minimized.

Member

frestr commented Apr 9, 2017

I thought about making it a play order plugin, but that doesn't make much sense the way I see it, as it doesn't really have that much to do with the play order.

I think having a separate configuration window for the queue would be nice, especially if we later want to add even more queue options not relating to the play order. Perhaps we could add a new "Queue" tab in the File->Preferences window?

@declension

This comment has been minimized.

Member

declension commented Apr 9, 2017

Yep I think all it's a bit complicated conceptually and UI-wise both now and maybe forever. Essentially I wanted to provide a way to abstract the PlaylistMux better, and also unify the "Random" with Shuffle plugins (why can't the queue be shuffled in a weighted way, or whatever).

That way, this and the Queue only plugin could live somewhere a bit more meaningful. Though of course that then makes it more complicated, if slightly neater / more powerful.

...but again this is a whole separate piece really.

@frestr if you can make that text change, then assuming @lazka doesn't have anything I think it's good to go.

@declension declension merged commit ae00db0 into quodlibet:master Apr 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@declension

This comment has been minimized.

Member

declension commented Apr 12, 2017

Thanks

1 similar comment
@lazka

This comment has been minimized.

Member

lazka commented Apr 12, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment