New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ratings menu so it shows correct values #2355

Merged
merged 1 commit into from Apr 23, 2017

Conversation

Projects
None yet
3 participants
@IBBoard
Contributor

IBBoard commented Apr 11, 2017

Fixes #2350.

Code change extracts common function (because DRY) and stores ratings items with handler in array so that we can disable events before ticking/unticking boxes.

Based on 3.8 branch, because I'm running Stable.

@declension

Thanks, but please note all PRs should be against master, as our release branches are bugfix only, with occasional backports from master where deemed necessary.

If #2350 is already fixed in master we should of course close it.

@IBBoard

This comment has been minimized.

Contributor

IBBoard commented Apr 12, 2017

Quick examination of code history shows that the ratingsmenu.py file hasn't changed at all in master. Both modified 7b63ec3 on 8 Oct 2016

IBBoard
Update ratings menu so it shows correct values
 a) handles mixed ratings cleanly
 b) always shows correct values (previously some code passed the song
    object too late, so it was set from a "None" object)

@IBBoard IBBoard force-pushed the IBBoard:ratings-menu-fix-2 branch from 8d356e9 to 605a681 Apr 12, 2017

@IBBoard IBBoard changed the base branch from quodlibet-3.8 to master Apr 12, 2017

@IBBoard

This comment has been minimized.

Contributor

IBBoard commented Apr 12, 2017

Okay, branch kinda-rebased to Master (cherry-picked and force-branched, then force-pushed). Hopefully that worked.

@lazka

lazka approved these changes Apr 23, 2017

looks good

@lazka lazka merged commit 3561da8 into quodlibet:master Apr 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment