New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some css hackery to get a drag handle for the pane separator. #2402

Merged
merged 1 commit into from May 29, 2017

Conversation

Projects
None yet
3 participants
@lazka
Member

lazka commented May 28, 2017

So it's easier to see that these things can be moved.
Limited to gtk+ 3.22 for now as I haven't tested witholder versions.

@lazka

This comment has been minimized.

Member

lazka commented May 28, 2017

Any opinions on this?

screenshot from 2017-05-28 13-45-09

@frestr

This comment has been minimized.

Member

frestr commented May 28, 2017

I think it looks alright. Can possibly be a little distracting in the presence of many panes, but that's just nitpicking. I also tested with gtk+ 3.18 (just removed the conditional), and it didn't seem to work there.

@lazka lazka force-pushed the lazka:pane-drag-handle branch from 9a9d8b7 to 2122ae6 May 28, 2017

@lazka

This comment has been minimized.

Member

lazka commented May 28, 2017

OK, a bit less contrast maybe?

screenshot from 2017-05-28 17-28-05

Add some css hackery to get a drag handle for the pane separator.
So it's easier to see that these things can be moved.
Limited to gtk+ 3.22 for now as I haven't tested witholder versions.

@lazka lazka force-pushed the lazka:pane-drag-handle branch from 2122ae6 to 85ffbd6 May 28, 2017

@frestr

This comment has been minimized.

Member

frestr commented May 28, 2017

Yeah, I think it looks better now!

@urielz

This comment has been minimized.

Contributor

urielz commented May 28, 2017

Looks good. It's a nice touch.

@lazka lazka merged commit d032f1a into quodlibet:master May 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lazka added a commit that referenced this pull request Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment