New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely lazy fix for #138 #2466

Merged
merged 3 commits into from Jul 8, 2017

Conversation

Projects
None yet
2 participants
@sauyon
Contributor

sauyon commented Jul 5, 2017

This just uses $XDG_CONFIG_HOME/quodlibet as the default directory unless it doesn't exist and ~/.quodlibet does.

I'm willing to go through and actually put files where they should be if that's necessary.

EDIT: For #138.

@@ -118,7 +118,16 @@ def get_user_dir():
if os.name == "nt":
USERDIR = os.path.join(windows.get_appdate_dir(), "Quod Libet")
else:
USERDIR = os.path.join(os.path.expanduser("~"), ".quodlibet")
if 'XDG_CONFIG_DIR' in environ:

This comment has been minimized.

@lazka

lazka Jul 8, 2017

Member

Use quodlibet.util.path.xdg_get_config_home

@@ -118,7 +118,16 @@ def get_user_dir():
if os.name == "nt":
USERDIR = os.path.join(windows.get_appdate_dir(), "Quod Libet")
else:

This comment has been minimized.

@lazka

lazka Jul 8, 2017

Member

We don't want this change on macOS (quodlibet.util.is_osx), needs a new case using the old path for this.

@lazka

This comment has been minimized.

Member

lazka commented Jul 8, 2017

Notice the code quality tests failing. You can run them locally using either "setup.py quality" or "py.test tests/quality"

@sauyon

This comment has been minimized.

Contributor

sauyon commented Jul 8, 2017

I'm seeing a bunch of quality errors from stuff in optpackages but I'm assuming I'm to ignore those; can I turn them off?

@lazka

This comment has been minimized.

Member

lazka commented Jul 8, 2017

uh, optpackages should get skipped for this (in tests.quality.util.iter_project_py_files())

@sauyon

This comment has been minimized.

Contributor

sauyon commented Jul 8, 2017

It might be worth moving the check for QUODLIBET_USERDIR/build type above to speed up launches (slightly).

@sauyon

This comment has been minimized.

Contributor

sauyon commented Jul 8, 2017

Ah - it was finding them in build/lib/quodlibet/optpackages. Getting rid of that worked fine (maybe it should ignore root/build as well?).

@lazka

This comment has been minimized.

Member

lazka commented Jul 8, 2017

Ah, right, thanks. I'll have a look.

edit: e443223

@lazka

lazka approved these changes Jul 8, 2017

@lazka lazka merged commit 4e9545b into quodlibet:master Jul 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lazka

This comment has been minimized.

Member

lazka commented Jul 8, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment