Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Album art mods #2511
Here I aim to improve the Album Art Downloading experience
This is achieved (certainly it is/was for me ..but hopefully this will affect others usage positively too) via this patch set which i split into two parts. Please read the notes having looked at the pictures for context in each instance.
1. Custom filename for output
image: pre custom filename
So to be clear.. with the changes, I can set custom filenames for the download target, without, I cannot. That is why I wish this to be included in quodlibet.
2. Search string clarity and custom search sizes
image: search changes
image: original search example
image: new 'raw' search
So to be clear.. with the changes, I can get the search results I want from both cover providers, without, I cannot. That is why I wish this to be included in quodlibet. Given quodlibet is (IMO) pitched at a slightly more advanced user, I don't think they'd baulk at exposure to this extra detail either.
Further implementation notes:
Well after struggling with a 'Gtk.init_check' issue for a while, which (miraculously) disappeared all of a sudden (I was initially blindly calling newly installed py.test with '-s' param and as it turns out 's' is not for 'script', so maybe it was that) ..the failing test ran without issue. 28 others failed but that's mainly due to my env (e.g. no pyflakes etc.)
The failing test only fails on the 'debian8-py2' bot so if anyone with that env available could shed more light that would be great.
Further, the error in question (caused by Gtk.init_check() failure)..
..occurs for me at random if I rapidly repeat the test.. sometimes pass, sometimes fail. Could the same be occurring on the build bot?
Apologies that this has taken me so long to come back on. Sadly, my initial reaction was that I'd given sufficient detail, specifically with commit names like:
-allow configurable custom files names for downloaded art
but perhaps the final feature, implemented in:
So I've re-written the initial message and added many more pictures ..it does read much better than the initial attempt, and now, hopefully, even for someone who hasn't necessarily seen/used the 'Album Art Downloader' it should be enough to gauge exactly what I'm doing. The problem is, that this write up has taken me about as long it did to change the code ..and personally, that isn't a balance that I find workable.
Given that you (Lazka), are effectively a deity to me (even given my limited knowledge of what you do / have achieved in the OS community) could you humour me sufficiently to elaborate on what wasn't there originally? (lol ..difficult now I've deleted it, but maybe you recall?)
Excuse the jumping in here... I've re-read the changes and understand better now (thanks for the updates / pictures). Whilst I get reducing the number of PRs, AIUI there are definitely two separate things going on:
Can I be annoying and ask you to split the second out to a separate PR? Then the first one could be merged easier, notwithstanding any comments from @lazka