New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acoustic fingerprint plugin fixes #2530

Merged
merged 4 commits into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@Mellthas
Contributor

Mellthas commented Aug 13, 2017

Here are several fixes to the acoustic fingerprint plugins:

  1. Acoustic fingerprint submissions were missing the track title. The first commits also adds the track title to these. I don’t know if it was left out intentionally; but the web service accepts the track title as track (see https://acoustid.org/webservice).
  2. Fingerprint lookup and submission were not working with Python 3. The second commit fixes both.
  3. In the fingerprint submit dialog, opening the expander made the dialog very wide, and closing it did retain the large size. The third commit tries to smooth that behavior by making the expander affect the dialog size and making the contained label wrap.
  4. The button order in the dialog was inconsistent with most other dialogs (affirmative action normally on the right side).

Mellthas added some commits Aug 12, 2017

Improve sizing of fingerprint submit dialog
* Toggling the details expander affects the dialog size. That way, the dialog does not stay oddly large after opening and closing the expander again.
* The details label wraps to avoid the dialog becoming super wide.

@lazka lazka merged commit 3060bb6 into quodlibet:master Aug 14, 2017

8 checks passed

ci/circleci: job.debian8.py2 Your tests passed on CircleCI!
Details
ci/circleci: job.debian8.py3 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04.py2 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04.py3 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu17.10.py3 Your tests passed on CircleCI!
Details
ci/circleci: job.win32.py2 Your tests passed on CircleCI!
Details
ci/circleci: job.win32.py3 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lazka

This comment has been minimized.

Member

lazka commented Aug 14, 2017

Thanks

@Mellthas Mellthas deleted the Mellthas:acoustid-submit-fixes branch Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment