Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Waveform Seekbar time indication (#2419) #2550
This pull request fixes issue #2419:
Here is what it looks like with various popular gtk themes (from top to bottom: Adwaita-dark, Adwaita, Arc-Dark, Arc, Ambiance, Radiance):
As you can see the default "hover color" (the one to the left of the mouse cursor in the screenshots above) is not always great. It is computed by blending the two other colors, and I could not find any other way that works well for all the themes I tested. I hope it's good enough, considering that the three colors used in the waveform are configurable in the plugin's options. If not, I could remove the visual effect, and only change the time labels when hovering.
Hmm, I can't get it to work as intended here (with Ubuntu 17.04 + HiDPI). The hovering seems to un-highlight the played section when going back in time but not at all when going forwards, and can't ever go further than half way.
It can also result in highlighting that looks like dark-light-dark-none (screenshots force a redraw which fixes this issue, though, so can't show this)
@Muges thanks that fixes the DPI bugs.
Generally looks great to me. The only thing is the colours: I find it confusing that if you:
Perhaps the whole bar should be lighter on dragging (yes - this means you can't see the current position I guess, but it feels less strange than colours swapping meaning IMO)
Sep 10, 2017
8 checks passed
So if I understand this it is intended that hovering the waveform seekbar while a track is playing will hide the current position in the track and only show where you would seek to?
I miss having the current position show even when hovering
(I really like how it looks in the images in the first post)