New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Fix non-translatable strings. See #2166 #2576

Merged
merged 3 commits into from Sep 30, 2017

Conversation

Projects
None yet
2 participants
@krisse7
Contributor

krisse7 commented Sep 29, 2017

Fix non-translatable strings mentioned in #2166 and also other strings.

krisse7 added some commits Sep 27, 2017

Mark strings as translatable
Mark strings as translatable in the following places:
* Plugins: Gajim Status Message (see #2166)
* Plugins: Custom Commands
* Plugins: Send to iFP
* Edit Tags dialog / Rename Files tab
@lazka

This comment has been minimized.

Member

lazka commented Sep 30, 2017

Changing

w = qltk.WaitLoadWindow(None, len(songs), "Uploading %d/%d", (0, len(songs)))

to

w = qltk.WaitLoadWindow(None, len(songs), "Uploading %(current)d/%(total)d")

should fix the tests.

@krisse7

This comment has been minimized.

Contributor

krisse7 commented Sep 30, 2017

I didn't have polib installed so that test was skipped. Should be fixed now.

@lazka lazka merged commit ae7d939 into quodlibet:master Sep 30, 2017

8 checks passed

ci/circleci: job.debian8.py2 Your tests passed on CircleCI!
Details
ci/circleci: job.debian8.py3 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04.py2 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04.py3 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu17.10.py3 Your tests passed on CircleCI!
Details
ci/circleci: job.win32.py2 Your tests passed on CircleCI!
Details
ci/circleci: job.win32.py3 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lazka

This comment has been minimized.

Member

lazka commented Sep 30, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment