New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_editors: Fix capitalization and tied tags not translating. Fixes #2585 #2586

Merged
merged 1 commit into from Oct 12, 2017

Conversation

Projects
None yet
3 participants
@krisse7
Contributor

krisse7 commented Oct 12, 2017

Fix for #2585

  • Edit Columns: Use the same method to format column names that is used in the actual view.
  • Edit Custom Commands: Use capitalization instead of title case for parameters.

I left "New Command" title-cased as it is now. It is constructed dynamically ("New %s") and the second part ("Command") is already capitalized.

data_editors: Fix capitalization and tied tags not translating. Fixes #…
…2585

* Edit Columns: Use the same method to format column names that is used in the actual view.
* Edit Custom Commands: Use capitalization instead of title case for parameters.

@lazka lazka merged commit 2acfff9 into quodlibet:master Oct 12, 2017

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: job.debian8.py2 Your tests passed on CircleCI!
Details
ci/circleci: job.debian8.py3 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04.py2 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04.py3 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu17.10.py3 Your tests passed on CircleCI!
Details
ci/circleci: job.win32.py2 Your tests passed on CircleCI!
Details
ci/circleci: job.win32.py3 Your tests passed on CircleCI!
Details
@lazka

This comment has been minimized.

Member

lazka commented Oct 12, 2017

Thanks, looks good!

@declension

This comment has been minimized.

Member

declension commented on da635b2 Oct 12, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment