New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use inline separators when changing multiple tag values #2684

Merged
merged 3 commits into from Feb 28, 2018

Conversation

Projects
None yet
2 participants
@pfps
Contributor

pfps commented Jan 2, 2018

Leaving in the newline works much better.

pfps added some commits Jan 2, 2018

@pfps

This comment has been minimized.

Contributor

pfps commented Jan 2, 2018

I was trying to write tests for this but the functionality is buried in a class and I don't know how to access it in a test.

@declension declension merged commit f1c1a00 into quodlibet:master Feb 28, 2018

6 checks passed

ci/circleci: job.fedora26 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu17.10 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@declension

This comment has been minimized.

Member

declension commented Feb 28, 2018

Thanks. Sorry about the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment