New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waveformseekbar: Clamp seek time to valid range #2729

Merged
merged 1 commit into from Jan 17, 2018

Conversation

Projects
None yet
2 participants
@psimonyi

psimonyi commented Jan 17, 2018

Mouse move events can be delivered when the mouse is outside the widget during a drag, so treat x-positions beyond the end of the seek bar as just at the start or end.

Without this, dragging from the waveform seek bar outside its range will show seek times that are negative or past the end of the track (though it is properly clamped to the valid range once you release the mouse button).

Peter Simonyi
waveformseekbar: Clamp seek time to valid range
Mouse move events can be delivered when the mouse is outside the widget
during a drag, so treat x positions beyond the end of the seek bar as
just at the start or end.

@lazka lazka merged commit 81b4f42 into quodlibet:master Jan 17, 2018

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: job.fedora26 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu17.10 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@lazka

This comment has been minimized.

Member

lazka commented Jan 17, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment