New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize rating/playcount tags in vorbis comments #2761

Merged
merged 2 commits into from Feb 5, 2018

Conversation

Projects
None yet
2 participants
@slosd
Contributor

slosd commented Feb 5, 2018

Use lower-case keys when looking for rating/playcount tags from mutagen.

Recognize rating/playcount tags in vorbis comments. Fixes #2760
Use lower-case keys when looking for rating/playcount tags from mutagen.

@slosd slosd changed the title from Recognize rating/playcount tags in vorbis comments. Fixes #2760 to Recognize rating/playcount tags in vorbis comments Feb 5, 2018

@lazka

This comment has been minimized.

Member

lazka commented Feb 5, 2018

Can you add a test?

@slosd

This comment has been minimized.

Contributor

slosd commented Feb 5, 2018

Sure. I simply changed existing tests to include an upper-case letter in the email. Without my patch every single one fails all formats fail in new_email_rating and different_email_rating.

@lazka lazka merged commit 6d4445b into quodlibet:master Feb 5, 2018

6 checks passed

ci/circleci: job.fedora26 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu17.10 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment