New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli options for setting repeat and shuffle type #2799

Merged
merged 2 commits into from Mar 4, 2018

Conversation

Projects
None yet
2 participants
@frestr
Member

frestr commented Mar 3, 2018

Fixes #2785

There are a few things to consider here, which I would like to have some input on:

  • Should order plugins (like Reverse) also be adjustable via the command line? If so, what should happen if set while the plugin is not enabled?
  • Should changing the mode type also turn on the mode? Worth mentioning since setting multiple options at once doesn't seem to work too well.
  • This change appears to have some overlap with the '--order' option mentioned in the manpage, but that option doesn't seem to have been implemented... I'm also not sure if the format of the --order option maps too well against the GUI.
@lazka

This comment has been minimized.

Member

lazka commented Mar 4, 2018

Should order plugins (like Reverse) also be adjustable via the command line? If so, what should happen if set while the plugin is not enabled?

Not a big fan of exposing all this in the CLI, so I'd prefer a minimal implementation, if at all.

Should changing the mode type also turn on the mode? Worth mentioning since setting multiple options at once doesn't seem to work too well.

What about yes, turn on the mode, and in addition add an "off" option to both repeat-type/shuffle-type? That way it's just a more specialized variant of the non-type commands and can be used independently.

This change appears to have some overlap with the '--order' option mentioned in the manpage, but that option doesn't seem to have been implemented... I'm also not sure if the format of the --order option maps too well against the GUI.

Yeah, that got lost in the last rewrite, should be removed from the man page. Please ignore.

lazka added a commit that referenced this pull request Mar 4, 2018

@frestr

This comment has been minimized.

Member

frestr commented Mar 4, 2018

Not a big fan of exposing all this in the CLI, so I'd prefer a minimal implementation, if at all.

Ok, then I think we'll keep it as it is now.

What about yes, turn on the mode, and in addition add an "off" option to both repeat-type/shuffle-type? That way it's just a more specialized variant of the non-type commands and can be used independently.

Sounds good.

@lazka lazka merged commit 73fda91 into quodlibet:master Mar 4, 2018

6 checks passed

ci/circleci: job.fedora26 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu17.10 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@frestr frestr deleted the frestr:cli_modes branch Mar 5, 2018

elbeardmorez added a commit to elbeardmorez/quodlibet that referenced this pull request Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment