New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue stop once empty: do check at end of song instead #2801

Merged
merged 2 commits into from Mar 6, 2018

Conversation

Projects
None yet
2 participants
@frestr
Member

frestr commented Mar 4, 2018

Stops playback directly when a song has ended and the queue is empty, as opposed to enabling the "Stop After Empty" setting when the last song has started.

See #2774

@frestr frestr referenced this pull request Mar 4, 2018

Closed

It still will not STOP #2774

@catmatist

This comment has been minimized.

catmatist commented Mar 5, 2018

Interesting. What if you play a song directly, not going through the queue? With this change, will Quodlibet honor the "stop if queue is empty" flag when that song ends, or does that situation bypass this code entirely? I'll try to find time to figure out how to pull this from GitHub and test it, but it might take awhile as I'm new to this site.

@frestr

This comment has been minimized.

Member

frestr commented Mar 5, 2018

As it is now, playing a song directly will not bypass the setting. When I come to think of it, this is exactly the same as how Repeat>One Song works, so this is not really desirable.

IMO, playing a song directly should bypass the setting, while it is honored as long as you are playing from the queue. This makes it so that the setting doesn't have to be disabled when not playing from the queue.

If you want to test it, you can follow the instructions at Creating a Development Environment. The only difference will be that instead of cloning the main repo (git clone https://github.com/quodlibet/quodlibet.git), you'll have to clone my fork of it (git clone https://github.com/frestr/quodlibet.git) and change to the queue_stop_fix branch (git checkout queue_stop_fix) inside the cloned repo.

@catmatist

This comment has been minimized.

catmatist commented Mar 5, 2018

This is so frustrating! You had it working the way I wanted, and then when I asked how it worked, you changed it and made it useless. Or at least, that is the case if I have understood what you have said about how each version works. Does no one understand the idea that whenever possible, options should have the effect they say they have, and not something subtly different instead? Do I have to check and see if the "one song" option has no effect when songs are playing from the queue? Because the effect I was looking for was exactly that to play more than one song, I can add them to the queue, but if I just "play" a song, Quodlibet does not go on to play some other song that I did not tell it to play.

@frestr

This comment has been minimized.

Member

frestr commented Mar 6, 2018

See my reply at #2774

@frestr frestr merged commit 406571c into quodlibet:master Mar 6, 2018

6 checks passed

ci/circleci: job.fedora26 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu17.10 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment