Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse DNS app ID #2842

Merged
merged 8 commits into from May 13, 2018
Merged

Reverse DNS app ID #2842

merged 8 commits into from May 13, 2018

Conversation

@fkrull
Copy link
Contributor

@fkrull fkrull commented May 12, 2018

See issue #2792. I renamed everything I could find that needs to match the Flatpak app ID, in particular:

  • the desktop file
  • the appdata file
  • the D-Bus names
  • the application icon
  • the GNOME search provider

This does mean the net.sacredchao.QuodLibet D-Bus name goes away. Any third-party clients using that name that may or may not exist would have to be updated.

I also added StartupWMClass to the desktop file. Without it, Unity had difficulties matching the window to the desktop file.

I left Ex Falso alone for the moment.

@lazka
Copy link
Member

@lazka lazka commented May 13, 2018

Thanks!

Can your revert the "quodlibet/quodlibet/qltk/dbus_.py" changes?

I'd prefer if it just gets blocked in flatpak (is that a problem?), and once we move MPRIS into the core we might drop it altogether.

This is only for the custom D-Bus API. The D-Bus objects that implement
some external interface still use io.github.quodlibet.QuodLibet.
@fkrull
Copy link
Contributor Author

@fkrull fkrull commented May 13, 2018

I played around with it and it turns out that yes, I can. ;) I left the other D-Bus names (search provider and the app menu) as-is since no one should write those names down and talk to them.

@lazka lazka merged commit 68fd50c into quodlibet:master May 13, 2018
6 checks passed
6 checks passed
ci/circleci: job.fedora26 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu17.10 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lazka
Copy link
Member

@lazka lazka commented May 13, 2018

Thanks :)

@fkrull fkrull deleted the fkrull:reverse-dns-app-id branch May 13, 2018
@CreamyCookie
Copy link
Collaborator

@CreamyCookie CreamyCookie commented Jun 4, 2018

Regarding the icon, it seems that with this change, every icon pack (Numix Square, for example) has to create a symlink from "quodlibet" to "io.github.quodlibet.QuodLibet". It's not a big hassle, but is that change necessary?

@lazka
Copy link
Member

@lazka lazka commented Jun 4, 2018

It's not a big hassle, but is that change necessary?

afaik we could have only done it for the flatpak build, but then you would have two names depending on how things are installed. But maybe I've missed something?

@fkrull
Copy link
Contributor Author

@fkrull fkrull commented Jun 4, 2018

afaik we could have only done it for the flatpak build, but then you would have two names depending on how things are installed

Well, there's no way to not rename the icon for Flatpak. Having both names sounds like a maintenance nightmare to me, especially considering how many places this PR ended up touching. Also, any icon theme would have to support both names anyway if they want to work for Flatpak installations.

@CreamyCookie
Copy link
Collaborator

@CreamyCookie CreamyCookie commented Jun 4, 2018

Makes sense! I'm looking forward to flatpak support. =)

@lazka
Copy link
Member

@lazka lazka commented Jun 4, 2018

Makes sense! I'm looking forward to flatpak support. =)

No need to wait :) https://flathub.org/apps/details/io.github.quodlibet.QuodLibet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants