New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Polish translation for 4.1 #2857

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
3 participants
@piotrdrag
Contributor

piotrdrag commented May 20, 2018

Please also cherry-pick to master.

@lazka

This comment has been minimized.

Member

lazka commented May 21, 2018

/home/user/app/quodlibet/po/pl.po:6031: a format specification for argument 'title', as in 'msgstr[0]', doesn't exist in 'msgid_plural'
/home/user/app/quodlibet/po/pl.po:6081: number of format specifications in 'msgid_plural' and 'msgstr[0]' does not match
@piotrdrag

This comment has been minimized.

Contributor

piotrdrag commented May 21, 2018

These look correct in the translation:

#, python-format
msgid "Remove track: \"%(title)s\" from library?"
msgid_plural "Remove %(count)d tracks from library?"
msgstr[0] "Usunąć ścieżkę „%(title)s” z kolekcji?"
msgstr[1] "Usunąć %(count)d ścieżki z kolekcji?"
msgstr[2] "Usunąć %(count)d ścieżek z kolekcji?"
#: ../quodlibet/qltk/songsmenu.py:422
#, python-format
msgid "_Show in File Manager"
msgid_plural "_Show %d Files in File Manager"
msgstr[0] "_Wyświetl w menedżerze plików"
msgstr[1] "_Wyświetl %d pliki w menedżerze plików"
msgstr[2] "_Wyświetl %d plików w menedżerze plików"
@lazka

This comment has been minimized.

Member

lazka commented May 21, 2018

hm, weird, I'll have a look

@declension

This comment has been minimized.

Member

declension commented May 22, 2018

Hmmm the second is probably my fault.

I thought gettext allowed you to have different numbers of arguments across plurals, but maybe not...

lazka added a commit that referenced this pull request May 22, 2018

Some gettext usage fixes. See #2857 and #2860
For the remove track one: gettext doesn't seem to like extra format specs
in ngettext, instead escape them and format after the translation.

For the show in file manager one: format after translation, not before.

lazka added a commit that referenced this pull request May 22, 2018

Some gettext usage fixes. See #2857 and #2860
For the remove track one: gettext doesn't seem to like extra format specs
in ngettext, instead escape them and format after the translation.

For the show in file manager one: format after translation, not before.
@lazka

This comment has been minimized.

Member

lazka commented May 22, 2018

I've pushed some (hopefully) fixes. Please try to rebase.

I'll add some tests so this doesn't happen again.

@lazka

This comment has been minimized.

Member

lazka commented May 22, 2018

I've added a test in 275b31b

@piotrdrag piotrdrag force-pushed the piotrdrag:pl-update-4.1 branch from 2149f85 to 579c3e7 May 22, 2018

@piotrdrag

This comment has been minimized.

Contributor

piotrdrag commented May 22, 2018

msgfmt doesn’t complain anymore. Thanks!

@lazka lazka merged commit c0004f7 into quodlibet:quodlibet-4.1 May 22, 2018

6 checks passed

ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@piotrdrag piotrdrag deleted the piotrdrag:pl-update-4.1 branch May 22, 2018

@lazka

This comment has been minimized.

Member

lazka commented May 22, 2018

Thanks!

master: a1b9ab0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment