Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make queue able to keep songs after playing them #2865
This PR adds a new checkbox to the queue preferences - "Keep Songs".
When enabled, the queue will get a "CurrentColumn" and act more like the main song list. Songs can be added to the queue as normal, but they will be kept in the queue when playing them.
When "Keep Songs" is enabled, it's also possible to enable the "Prioritize Queue" checkbox. If the user selects a song in the main song list with this option enabled, then the player will switch to the queue after the song is done playing. This is the same as how the queue works now.
If "Prioritize Queue" is disabled, then the player will not switch to queue automatically (but rather play the next song in the main song list), and the user will have to click on a song in the queue to begin playing from it again. This makes it possible to occasionally ignore the queue without having to clear it.
It is quite rough around the edges, and some feedback would be very appreciated.
Some things to consider:
Works nicely from quick test :)
Nothing comes to mind, except "Remove Finished Songs" which is on by default, but I'm not sure that's better.
We could have a "pause" button on the queue which makes things just ignore it as if it was empty in all cases.
feel free to merge this and leave potential improvements for later
(I wont be cherry picking this to 4.1)
Thanks for the feedback!
I like that idea. Would be useful for the original queue behavior too.
All right. I'll finish it up and try to add some tests too.