Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Inhibit Screensaver extension to GDBus #2876

Merged
merged 4 commits into from Jun 7, 2018
Merged

Conversation

@qarkai
Copy link
Collaborator

@qarkai qarkai commented Jun 6, 2018

According to https://www.freedesktop.org/wiki/Software/DBusBindings/ dbus-python is obsolete. This patch starts porting QL to recommended GDBus binding.

@lazka
Copy link
Member

@lazka lazka commented Jun 6, 2018

Please use GLib.Error instead of Exception for error handling

@lazka lazka merged commit 881444c into quodlibet:master Jun 7, 2018
6 checks passed
6 checks passed
ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lazka
Copy link
Member

@lazka lazka commented Jun 7, 2018

Thanks!

@qarkai qarkai deleted the qarkai:gdbus branch Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants