Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port util.environment module to GDBus #2885

Merged
merged 2 commits into from Jun 14, 2018
Merged

Port util.environment module to GDBus #2885

merged 2 commits into from Jun 14, 2018

Conversation

@qarkai
Copy link
Collaborator

@qarkai qarkai commented Jun 14, 2018

According to https://www.freedesktop.org/wiki/Software/DBusBindings/ dbus-python is obsolete. This patch ports another QL module to recommended GDBus binding.

@@ -22,14 +22,20 @@ def _dbus_name_owned(name):
return False

try:
import dbus
from gi.repository import Gio
from gi.repository import GLib
except ImportError:

This comment has been minimized.

@lazka

lazka Jun 14, 2018
Member

remove the try/except, we depend on gio/glib on all platforms

QL depends on gio/glib on all platforms.
@lazka lazka merged commit 32a3a7c into quodlibet:master Jun 14, 2018
5 of 6 checks passed
5 of 6 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@qarkai qarkai deleted the qarkai:gdbus-3 branch Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants