Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port util.environment module to GDBus #2885

merged 2 commits into from Jun 14, 2018


Copy link

@qarkai qarkai commented Jun 14, 2018

According to dbus-python is obsolete. This patch ports another QL module to recommended GDBus binding.

@@ -22,14 +22,20 @@ def _dbus_name_owned(name):
return False

import dbus
from gi.repository import Gio
from gi.repository import GLib
except ImportError:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the try/except, we depend on gio/glib on all platforms

QL depends on gio/glib on all platforms.
@lazka lazka merged commit 32a3a7c into quodlibet:master Jun 14, 2018
@qarkai qarkai deleted the gdbus-3 branch June 14, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants