New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port GNOME multimedia keys backend to GDBus #2918

Merged
merged 3 commits into from Jul 24, 2018

Conversation

Projects
None yet
1 participant
@qarkai
Collaborator

qarkai commented Jul 22, 2018

According to https://www.freedesktop.org/wiki/Software/DBusBindings/ dbus-python is obsolete. This patch ports GNOME multimedia keys backend to recommended GDBus binding.
Also moved dbus_name_owned() utility function to dbusutils.py.

qarkai added some commits Jul 22, 2018

Port GNOME multimedia keys backend to GDBus
Also moved dbus_name_owned() utility function to dbusutils.py
Revert moving dbus_name_owned() to dbusutils.py
Until dbusutils.py ported to GDBus binding. Otherwise it breaks
working on macOS and Windows.

@qarkai qarkai merged commit 7f72df2 into quodlibet:master Jul 24, 2018

6 checks passed

ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@qarkai qarkai deleted the qarkai:mmkeys-gnome-gdbus branch Jul 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment