Scrolling the mouse wheel seeks waveform seekbar #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PyGObject, you can either override |
|
Ah, thanks! I couldn't find very good docs on events in PyGObject so I had to guess somewhat using the GTK reference on events and what the other plugins had done. Should be fixed now. |
|
Great! This is the other main thing the waveform seekbar was missing for me. Thanks for adding it. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar functionality to that available with the alternative seekbar.
I considered making the seek amount setting in seconds instead of milliseconds because I couldn't think of a use case for millisecond accuracy and I felt it would be clearer. I settled on milliseconds since that is the precision it can offer. If people think seconds would be better I can switch to that fairly easily.
The workaround for the double calls of the scroll callback was the best I could come up with. Getting my callback called with 2 different numbers of arguments baffled me. Is this a bug with PyGObject?