New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling the mouse wheel seeks waveform seekbar #2930

Merged
merged 6 commits into from Aug 11, 2018

Conversation

Projects
None yet
4 participants
@blimmo
Contributor

blimmo commented Aug 5, 2018

Similar functionality to that available with the alternative seekbar.

I considered making the seek amount setting in seconds instead of milliseconds because I couldn't think of a use case for millisecond accuracy and I felt it would be clearer. I settled on milliseconds since that is the precision it can offer. If people think seconds would be better I can switch to that fairly easily.

The workaround for the double calls of the scroll callback was the best I could come up with. Getting my callback called with 2 different numbers of arguments baffled me. Is this a bug with PyGObject?

@sjohannes

This comment has been minimized.

sjohannes commented Aug 6, 2018

double calls of the scroll callback

In PyGObject, you can either override do_<signal_name>, or connect to the signal; don't do both.

@blimmo

This comment has been minimized.

Contributor

blimmo commented Aug 6, 2018

Ah, thanks! I couldn't find very good docs on events in PyGObject so I had to guess somewhat using the GTK reference on events and what the other plugins had done. Should be fixed now.

@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Aug 6, 2018

Great! This is the other main thing the waveform seekbar was missing for me. Thanks for adding it. 👍

@lazka lazka merged commit 93b8a5a into quodlibet:master Aug 11, 2018

6 checks passed

ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment