New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tag plugin #2936

Merged
merged 5 commits into from Aug 19, 2018

Conversation

Projects
None yet
3 participants
@blimmo
Contributor

blimmo commented Aug 13, 2018

A plugin to match missing tags. Would (kind of) close #1940

@frestr

This comment has been minimized.

Member

frestr commented Aug 14, 2018

Works nicely from a quick test.

It would probably be a good idea to strip the tag though, as queries like @(missing: date) and @(missing:date) do not yield the same results.

@blimmo

This comment has been minimized.

Contributor

blimmo commented Aug 14, 2018

I added a strip to the body as requested.

I'm a little unhappy with the handling of numeric tags. E.g. rating must be entered as ~#rating. I believe this could be fixed by using the call interface of data instead of the dict one but when I do that @(missing:rating) matches everything.

Since this is a plugin I think merging it as is will be fine but if there are any ideas to improve this behaviour they'd be welcome.

@frestr

This comment has been minimized.

Member

frestr commented Aug 15, 2018

I believe this could be fixed by using the call interface of data instead of the dict one but when I do that @(missing:rating) matches everything.

You still need to include the ~# prefix when using the call interface.

Even though ~ and # are metacharacters, they are still part of the tag key, so rating, ~rating and ~#rating are regarded as different tags. I guess it would be possible to introduce some kind of fallback mechanism, but that may introduce ambiguity and perhaps be a bit confusing.

A list of the internal tags (with the prefix included) exists in the documentation, so I don't consider it an issue having to use the whole tag key.

@lazka lazka merged commit 62e0673 into quodlibet:master Aug 19, 2018

6 checks passed

ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment