Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2859 Replace scale's label with a SpinButton in pitch plugin's parameters #2950

Merged
merged 1 commit into from Aug 29, 2018

Conversation

@LudoBike
Copy link
Contributor

@LudoBike LudoBike commented Aug 29, 2018

It just implements the proposition of issue #2859. So I add a SpinButton for each scale, give the scale and the SpinButton the same Adjustement object seems to be enough to sync their value.

@frestr
Copy link
Member

@frestr frestr commented Aug 29, 2018

Looks good, thanks :)

@frestr frestr merged commit 864492b into quodlibet:master Aug 29, 2018
6 checks passed
6 checks passed
ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@LudoBike LudoBike deleted the LudoBike:issue2859 branch Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants