Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2499 − Add the missing support for the Gnome Multimedia Keys #2954

Merged
merged 2 commits into from Sep 3, 2018

Conversation

@LudoBike
Copy link
Contributor

@LudoBike LudoBike commented Sep 1, 2018

Features

These commits implement support of Repeat, Shuffle, Rewind and Forward mmkeys in GnomeBackend and KeybinderBackend according to issue #2499 (if this pull request is accepted the issue could be close).

Tests

The callbacks are all ok and tested.

Using xdotool (as described in #2499) with KeybinderBackend, RandomPlay and Repeat are not catch.

I don't test the GnomeBackend, if there is any gnome user, feel free to try.

@lazka lazka merged commit 6ba95ed into quodlibet:master Sep 3, 2018
6 checks passed
6 checks passed
ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lazka
Copy link
Member

@lazka lazka commented Sep 3, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants