Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix -- Right Click Menu Crash in Edit Tag Window #2968

Merged
merged 1 commit into from Sep 13, 2018

Conversation

@Eoin-ONeill-Yokai
Copy link
Contributor

@Eoin-ONeill-Yokai Eoin-ONeill-Yokai commented Sep 13, 2018

I fixed a crash that complained about adding a list and a map together. The following is the crash report I received:

TypeError: unsupported operand type(s) for +: 'map' and 'list'
------
Traceback (most recent call last):

  File "/usr/lib/python3/dist-packages/quodlibet/qltk/edittags.py", line 632, in __popup_menu
    [1])

TypeError: unsupported operand type(s) for +: 'map' and 'list'

Converting the map to a list allows the addition of these elements, but I'd like to hear if this is actually the desired behavior? Never-the-less, this PR solves the bug and seems to run well on my local repository.

This is my first commit to this project, so hopefully it meets your standards.

@Eoin-ONeill-Yokai Eoin-ONeill-Yokai force-pushed the Eoin-ONeill-Yokai:master branch from 26813fb to 965d573 Sep 13, 2018
Fixed a crash that complained about adding a list and a map together. Solved this issue but converting the map to a list before addition.
@Eoin-ONeill-Yokai Eoin-ONeill-Yokai force-pushed the Eoin-ONeill-Yokai:master branch from 965d573 to 5bfa623 Sep 13, 2018
@lazka lazka merged commit 2dc6411 into quodlibet:master Sep 13, 2018
6 checks passed
6 checks passed
ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lazka
Copy link
Member

@lazka lazka commented Sep 13, 2018

Sentry issue: QUODLIBET-9C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants