New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2959: waveformseekbar UI freeze with streams #2987

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@ohel
Collaborator

ohel commented Oct 3, 2018

Fixes issue #2959: waveformseekbar UI freeze with streams.

Another place to fix this could be the set_interval method in TimeTracker (tracker.py) - maybe it should not accept a value of 0 at all and just use the default 1000ms if it gets 0 as input value. If that'd be a better place, I can push another commit.

@lazka lazka merged commit 5b64dd4 into quodlibet:master Oct 4, 2018

6 checks passed

ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
quodlibet.quodlibet #20181003.1 succeeded
Details
@lazka

This comment has been minimized.

Member

lazka commented Oct 4, 2018

thanks!

@ohel ohel deleted the ohel:waveformseekbar_stream_fix branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment