Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save custom eq presets #2995

Merged
merged 4 commits into from Oct 19, 2018
Merged

Save custom eq presets #2995

merged 4 commits into from Oct 19, 2018

Conversation

@ohel
Copy link
Collaborator

@ohel ohel commented Oct 16, 2018

Implements #2389 (saving and loading of custom EQ presets) and makes the UI a bit more user friendly. Should be backwards compatible with old config files (converts them when loading).

@ohel
Copy link
Collaborator Author

@ohel ohel commented Oct 16, 2018

There seems to be some kind of failure in one of the CI jobs, but it looks like some sort of generic Docker error. Edit: now that I looked at it a second time, it's just curl failing to get code coverage results. Any way to retry?

@frestr
Copy link
Member

@frestr frestr commented Oct 16, 2018

Yeah, it happens sometimes. I did a rerun for you.

Copy link
Member

@frestr frestr left a comment

Thanks for the PR, looks good to me.

The only thing (in addition to my other comment) would be to maybe not allow the empty string as a preset name (the save button can be greyed out if no input is provided).

quodlibet/quodlibet/ext/events/equalizer.py Outdated Show resolved Hide resolved
@frestr frestr merged commit 0e2eaa1 into quodlibet:master Oct 19, 2018
6 checks passed
6 checks passed
ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
quodlibet.quodlibet #20181018.2 succeeded
Details
@ohel ohel deleted the ohel:save_custom_eq_presets branch Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants