Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #2380: remember filelist scroll position on tag save #3005

Merged
merged 1 commit into from Oct 21, 2018

Conversation

@ohel
Copy link
Collaborator

@ohel ohel commented Oct 21, 2018

Fixes usability issue #2380: the file list was always scrolled to top when saving tags in Ex Falso. Now it remembers the position.

I had to handle this with the draw signal, as any attempts to change the vadjustment during other signals were in vain - the scroll position was always reset.

@lazka lazka merged commit 8e22c68 into quodlibet:master Oct 21, 2018
5 of 6 checks passed
5 of 6 checks passed
quodlibet.quodlibet #20181021.11 failed
Details
ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lazka
Copy link
Member

@lazka lazka commented Oct 21, 2018

We have a similar thing for the main songlist where we scroll to the re-selected row after refill.

@ohel ohel deleted the ohel:ef_remember_filelist_position branch Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants