Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause/Play doesnt work on first time #41

Closed
waseem01 opened this issue Jul 11, 2016 · 12 comments
Closed

Pause/Play doesnt work on first time #41

waseem01 opened this issue Jul 11, 2016 · 12 comments
Assignees
Labels

Comments

@waseem01
Copy link

  1. Launch app
  2. Tap on Surah Baqarah
  3. Tap play button at the bottom.
  4. Observe, button first shows play mode and then changes to pause mode
  5. Tap the button, the recitation doesnt stop, tap again, now it stops
  6. This happens only first time for any surah when its loaded.
@waseem01
Copy link
Author

I will fix this inshaAllah, @mohamede1945 please add me to the project so I can assign it to myself

@ahmedre
Copy link

ahmedre commented Jul 11, 2016

@waseem01 @mohamede1945 i've added an "in progress" label that we can label things people are working on with instead of adding to the project.

@waseem01
Copy link
Author

@ahmedre Thanks, I dont have 'write permissions' to the repo to move it :)

@ahmedre
Copy link

ahmedre commented Jul 11, 2016

we're not adding people with write permissions to the project right now for a few reasons:

  1. as a "github organization," we pay depending on the members in the organization
  2. we want to restrict checkin permissions to the code so only approved pull requests get merged

i also looked to see if there's a way to just give permissions to add labels and what not, but i didn't see that, though i could have missed it.

@ahmedre
Copy link

ahmedre commented Jul 11, 2016

as an aside, most open source projects work this way - i.e. you don't get write permissions to most of the repositories to be able to contribute - the maintainers are responsible for looking at pull requests, reviewing them, and merging code accordingly.

@ahmedre
Copy link

ahmedre commented Jul 11, 2016

oh - and i forgot, most importantly - jazakAllah khairan in advance!

@waseem01
Copy link
Author

Thanks, I will open a PR and I guess the admin can merge.

@mohamede1945
Copy link
Collaborator

@waseem01 I don't know why I'm not able to reproduce the issue. Can you have tell me which reciter were you using?

@mohamede1945
Copy link
Collaborator

@ahmedre Thanks a lot for creating the label. I was mainly depending on zenhub for such things, but I think I should use labels too since it will be easier for everyone.

@mohamede1945 mohamede1945 added this to the V2 milestone Aug 20, 2016
@mohamede1945 mohamede1945 self-assigned this Aug 20, 2016
@mohamede1945
Copy link
Collaborator

Gif of the issue:
g7jxoq

@mohamede1945
Copy link
Collaborator

I'll start working on this issue now.

@mohamede1945 mohamede1945 removed this from the v1.1 milestone Apr 13, 2017
@mohamede1945
Copy link
Collaborator

Can't reproduce anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants