From 1008ce14704dc196dd9592f9fb5f1cf8f05c6267 Mon Sep 17 00:00:00 2001 From: Nabeel El-Husayni Date: Thu, 25 Jun 2020 20:01:46 -0400 Subject: [PATCH 1/5] Add explicit return type to pages/_app.tsx --- src/pages/_app.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/_app.tsx b/src/pages/_app.tsx index fb1e080939..94e61ebed1 100644 --- a/src/pages/_app.tsx +++ b/src/pages/_app.tsx @@ -5,7 +5,7 @@ import { theme } from '../utils/styles'; import { createSEOConfig } from '../utils/seo'; import Footer from '../components/Footer'; -function MyApp({ Component, pageProps }) { +function MyApp({ Component, pageProps }): JSX.Element { return ( From 3bda0f18a69e16f2f4048ecd5bb4fcf1ece1be2a Mon Sep 17 00:00:00 2001 From: Nabeel El-Husayni Date: Thu, 25 Jun 2020 20:04:04 -0400 Subject: [PATCH 2/5] touch a top level file --- .eslintrc.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.eslintrc.yml b/.eslintrc.yml index 75802dcd6b..48927e7464 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -34,4 +34,4 @@ overrides: react/react-in-jsx-scope: 0 # allow ts-ignore comments - "@typescript-eslint/ban-ts-ignore": 0 \ No newline at end of file + "@typescript-eslint/ban-ts-ignore": 0 From 2ab39e9b723e33ab19074694c84554889c315bcd Mon Sep 17 00:00:00 2001 From: Nabeel El-Husayni Date: Thu, 25 Jun 2020 20:06:10 -0400 Subject: [PATCH 3/5] Remove brackets around push in action def --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0d614556f1..ab0efdd0fe 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,6 +1,6 @@ name: Test -on: [push] +on: push jobs: test: From 47875f3f924b84e436fc25b85ec5d1dda55fd3b2 Mon Sep 17 00:00:00 2001 From: Nabeel El-Husayni Date: Thu, 25 Jun 2020 20:14:12 -0400 Subject: [PATCH 4/5] explicitly match against all files --- .github/workflows/test.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ab0efdd0fe..2922ca22e3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,6 +1,9 @@ name: Test -on: push +on: + push: + paths: + - '**' jobs: test: From b39b8fb7d1a8c112e1fb3b94023c4552f3ef0991 Mon Sep 17 00:00:00 2001 From: Nabeel El-Husayni Date: Thu, 25 Jun 2020 20:25:27 -0400 Subject: [PATCH 5/5] Add pull_request event to action --- .github/workflows/test.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2922ca22e3..cd3c0c4be7 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,9 +1,6 @@ name: Test -on: - push: - paths: - - '**' +on: [push, pull_request] jobs: test: