From 2d54c927e34abaead2366aeac5465da400b1a9f4 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 9 Jun 2016 15:16:49 +0200 Subject: [PATCH] Fix urlutils tests on Qt 5.6.1 For some reason the behaviour of QHostAddress("31c3").isValid() changed with Qt 5.6.1: https://bugreports.qt.io/browse/QTBUG-53983 This causes the test to fail because Qt thinks this is a valid IP, so we think it's a valid URL. --- tests/unit/utils/test_urlutils.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/unit/utils/test_urlutils.py b/tests/unit/utils/test_urlutils.py index dcfd6d57024..80c8a9e7057 100644 --- a/tests/unit/utils/test_urlutils.py +++ b/tests/unit/utils/test_urlutils.py @@ -336,7 +336,9 @@ def test_get_search_url_invalid(urlutils_config_stub, url): (False, True, False, '23.42'), # no DNS because bogus-IP (False, True, False, '1337'), # no DNS because bogus-IP (False, True, True, 'deadbeef'), - (False, True, False, '31c3'), # no DNS because bogus-IP + pytest.mark.xfail(qtutils.version_check('5.6.1'), + reason='Qt behaviour changed')( + False, True, False, '31c3'), # no DNS because bogus-IP (False, True, False, 'foo::bar'), # no DNS because of no host # Valid search term with autosearch (False, False, False, 'test foo'),