Permalink
Browse files

Fix crash when opening http://foo%40bar@baz

  • Loading branch information...
The-Compiler committed Aug 1, 2016
1 parent 1f930a5 commit 5ec39b7540c4e9e15012c866cf4946f7a042f05c
Showing with 14 additions and 0 deletions.
  1. +1 −0 CHANGELOG.asciidoc
  2. +4 −0 qutebrowser/browser/webkit/history.py
  3. +9 −0 tests/end2end/features/history.feature
View
@@ -42,6 +42,7 @@ Fixed
- Fixed crash when using hints with JS disabled in some rare circumstances.
- When hinting input fields (`:t`), also consider input elements without a type.
- Fixed crash when opening an invalid URL with a percent-encoded and a real @ in it
v0.8.1
------
@@ -295,6 +295,10 @@ def add_url(self, url, title="", *, redirect=False, atime=None):
"""
if config.get('general', 'private-browsing'):
return
if not url.isValid():
log.misc.warning("Ignoring invalid URL being added to history")
return
if atime is None:
atime = time.time()
entry = Entry(atime, url, title, redirect=redirect)
@@ -51,3 +51,12 @@ Feature: Page history
When I open data/title.html
And I run :history-clear
Then the history file should be empty
## Bugs
Scenario: Opening a valid URL which turns out invalid
When I set general -> auto-search to true
And I run :open http://foo%40bar@baz
Then "QFSFileEngine::open: No file name specified" should be logged
And "Error while loading : Host not found" should be logged
And "Ignoring invalid URL being added to history" should be logged

0 comments on commit 5ec39b7

Please sign in to comment.