Permalink
Browse files

tests: Mark "History with an error" as flaky

For some reason, sometimes on Travis the history file we read is empty.
I have no idea why though, as we successfully wait until ":save saved
history" is logged, and that is working fine.

Let's just mark the test as flaky for now so we can move on.
  • Loading branch information...
The-Compiler committed Jun 9, 2016
1 parent 288744c commit 9e1d20017c6e7a59083d1a2bc1af0e4710b0ffb2
Showing with 4 additions and 0 deletions.
  1. +1 −0 pytest.ini
  2. +2 −0 tests/conftest.py
  3. +1 −0 tests/end2end/features/history.feature
View
@@ -16,6 +16,7 @@ markers =
pyqt531_or_newer: Needs PyQt 5.3.1 or newer.
xfail_norun: xfail the test with out running it
ci: Tests which should only run on CI.
+ flaky_once: Try to rerun this test once if it fails
qt_log_level_fail = WARNING
qt_log_ignore =
^SpellCheck: .*
View
@@ -113,6 +113,8 @@ def pytest_collection_modifyitems(items):
_apply_platform_markers(item)
if item.get_marker('xfail_norun'):
item.add_marker(pytest.mark.xfail(run=False))
+ if item.get_marker('flaky_once'):
+ item.add_marker(pytest.mark.flaky(reruns=1))
def pytest_ignore_collect(path):
@@ -33,6 +33,7 @@ Feature: Page history
Then the history file should contain:
http://localhost:(port)/data/%C3%A4%C3%B6%C3%BC.html Chäschüechli
+ @flaky_once
Scenario: History with an error
When I run :open file:///does/not/exist
And I wait for "Error while loading file:///does/not/exist: Error opening /does/not/exist: *" in the log

0 comments on commit 9e1d200

Please sign in to comment.