Permalink
Browse files

QtWebEngine: Use loadFinished as history trigger

Using urlChanged spams the history with too many entries...

Fixes #1837
  • Loading branch information...
The-Compiler committed Aug 16, 2016
1 parent 1dbedbc commit cc693f17caa5cfcf0a2910d89132b5095f8677e0
Showing with 1 addition and 1 deletion.
  1. +1 −1 qutebrowser/browser/webengine/webenginetab.py
@@ -502,7 +502,7 @@ def _connect_signals(self):
page.linkHovered.connect(self.link_hovered)
page.loadProgress.connect(self._on_load_progress)
page.loadStarted.connect(self._on_load_started)
- page.loadStarted.connect(self._on_history_trigger)
+ page.loadFinished.connect(self._on_history_trigger)
view.titleChanged.connect(self.title_changed)
view.urlChanged.connect(self._on_url_changed)
page.loadFinished.connect(self._on_load_finished)

0 comments on commit cc693f1

Please sign in to comment.