Skip to content
Browse files
end2end tests: Don't fail with "STUB:" warnings
We have some things like pos_px stubbed which will fail any test because
of the stub warning - but some tests don't actually need that, it just
happens when e.g. loading something.

So let's not fail tests based on stub warnings, and see how much works
that way.
  • Loading branch information
The-Compiler committed Jul 13, 2016
1 parent 9c49900 commit e0ab70c8cff1c096d7a8d8c0ede043fe9fc57147
Showing with 4 additions and 1 deletion.
  1. +4 −1 tests/end2end/fixtures/
@@ -305,7 +305,10 @@ def _is_error_logline(self, msg):
is_ddg_load = testutils.pattern_match(
pattern="load status for <* tab_id=* url='*duckduckgo*'>: *",
return msg.loglevel > logging.INFO or is_js_error or is_ddg_load

is_log_error = (msg.loglevel > logging.INFO and
not msg.message.startswith('STUB:'))
return is_log_error or is_js_error or is_ddg_load

def _maybe_skip(self):
"""Skip the test if [SKIP] lines were logged."""

0 comments on commit e0ab70c

Please sign in to comment.