New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

private-browsing isn't passed to QtWebKit without restart #1742

Closed
The-Compiler opened this Issue Aug 2, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@The-Compiler
Collaborator

The-Compiler commented Aug 2, 2016

I just found out that due to a bug introduced in v0.2.0, qutebrowser doesn't tell QtWebKit to turn private browsing on when doing :set general private-browsing true.... 馃槰

Note this only applies to the running instance - on a fresh start with private-browsing in the config, the right thing happens.

I'm currently working on a fix and will release v0.8.2 today or tomorrow with it in. I'm still trying to find out what is impacted exactly. What I found out so far:

cache/cookies/history

  • cache: Not affected
  • cookies: Not affected
  • history: Not affected

html5 local storage

  • Websites can set local storage values with private browsing
  • The values get stored on disk (see ~/.local/share/qutebrowser/{local,offline}-storage)
  • After restarting, the new private session (with private browsing on correctly) can't read the values
  • Without private browsing, the values can be read (by the same website)

Other concerns

  • QtWebKit passes a private browsing setting to NPAPI plugins (like Flash). Not sure what happens with the setting after that.
  • QtWebKit has some more code to handle private browsing (e.g. for javascript console logging?) though that should be minor.
@The-Compiler

This comment has been minimized.

Show comment
Hide comment
@The-Compiler

The-Compiler Aug 2, 2016

Collaborator

Fixed in f73f3a2, keeping this open until the release.

Collaborator

The-Compiler commented Aug 2, 2016

Fixed in f73f3a2, keeping this open until the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment