New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QtWebEngine network stack for all downloads #2328

Open
The-Compiler opened this Issue Feb 20, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@The-Compiler
Collaborator

The-Compiler commented Feb 20, 2017

Currently, :download, hints and adblock filterlists use the QtNetwork stack for downloads with the QtWebEngine backend. They should use QtWebEngine downloads instead, though this is probably only possible after I pick up this Qt contribution.

@The-Compiler

This comment has been minimized.

Show comment
Hide comment
@The-Compiler

The-Compiler Jun 29, 2017

Collaborator

I submitted https://codereview.qt-project.org/#/c/198880/ now which hopefully makes it into Qt 5.10.

Collaborator

The-Compiler commented Jun 29, 2017

I submitted https://codereview.qt-project.org/#/c/198880/ now which hopefully makes it into Qt 5.10.

@The-Compiler

This comment has been minimized.

Show comment
Hide comment
@The-Compiler

The-Compiler Jul 21, 2017

Collaborator

The change above landed, so QWebEnginePage::download() will be in 5.10 🎉

Collaborator

The-Compiler commented Jul 21, 2017

The change above landed, so QWebEnginePage::download() will be in 5.10 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment