New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming ALL the settings #2708
Comments
nice to see this :) I think it is very good to be able to search the config options by full name |
I am a fan of the proposed explicit grouping as it's clear and allows for the notion of both sub configs (as illustrated in fonts.web...) but also might make it simple to express something as a domain specific config ( for example content.cookies.accept = no ... url(some.site.com).content.cookies.accept = yes ) That said though it would imply that every config should live in a group, for the oddballs at the top would 'browser' be an acceptable label? |
@notbenh That syntax isn't going to work, but there are some other plans to enable per-domain settings - they're documented in #499 for the most part, and unrelated to this in my eyes.
Why would it? |
I like this!
Could these be I'm thinking some kind of "formula" would be nice. Perhaps:
|
I would vote for |
Why? Neither Don't complexify with hierarchies when there is no need for it. Keep it simple. |
re: why I feel should everything be grouped: In the end, I'm not going to write the change so it's not something that I'm going to fight for. It is just a config structure, so even with un-grouped one-offs it's still going to work. |
Continue crusading, my man ;)
…On Jun 9, 2017 7:14 AM, "Florian Bruhin" ***@***.***> wrote:
With the current config revolution™ going on, it's a good time to rename
all settings to be more consistent and clear, or do any other breaking
changes. I'd like some input on that topic!
Current settings
For reference, here's how things look currently:
# general
ignore-case
startpage
yank-ignored-url-parameters
default-open-dispatcher
default-page
auto-search
auto-save-config
auto-save-interval
editor
editor-encoding
private-browsing
developer-extras
print-element-backgrounds
xss-auditing
site-specific-quirks
default-encoding
new-instance-open-target
new-instance-open-target.window
log-javascript-console
save-session
session-default-name
url-incdec-segments
# ui
history-session-interval
zoom-levels
default-zoom
downloads-position
status-position
message-timeout
message-unfocused
confirm-quit
zoom-text-only
frame-flattening
user-stylesheet
hide-scrollbar
css-media-type
smooth-scrolling
remove-finished-downloads
hide-statusbar
statusbar-padding
window-title-format
modal-js-dialog
hide-wayland-decoration
keyhint-blacklist
keyhint-delay
prompt-radius
prompt-filebrowser
# network
do-not-track
accept-language
referer-header
user-agent
proxy
proxy-dns-requests
ssl-strict
dns-prefetch
custom-headers
netrc-file
# completion
show
download-path-suggestion
timestamp-format
height
cmd-history-max-items
web-history-max-items
quick-complete
shrink
scrollbar-width
scrollbar-padding
# input
timeout
partial-timeout
insert-mode-on-plugins
auto-leave-insert-mode
auto-insert-mode
forward-unbound-keys
spatial-navigation
links-included-in-focus-chain
rocker-gestures
mouse-zoom-divider
# tabs
background-tabs
select-on-remove
new-tab-position
new-tab-position-explicit
last-close
show
show-switching-delay
wrap
movable
close-mouse-button
position
show-favicons
favicon-scale
width
pinned-width
indicator-width
tabs-are-windows
title-format
title-format-pinned
title-alignment
mousewheel-tab-switching
padding
indicator-padding
# storage
download-directory
prompt-download-directory
remember-download-directory
maximum-pages-in-cache
object-cache-capacities
offline-storage-default-quota
offline-web-application-cache-quota
offline-storage-database
offline-web-application-storage
local-storage
cache-size
# content
allow-images
allow-javascript
allow-plugins
webgl
css-regions
hyperlink-auditing
geolocation
notifications
media-capture
javascript-can-open-windows-automatically
javascript-can-close-windows
javascript-can-access-clipboard
ignore-javascript-prompt
ignore-javascript-alert
local-content-can-access-remote-urls
local-content-can-access-file-urls
cookies-accept
cookies-store
host-block-lists
host-blocking-enabled
host-blocking-whitelist
enable-pdfjs
# hints
border
mode
chars
min-chars
scatter
uppercase
dictionary
auto-follow
auto-follow-timeout
next-regexes
prev-regexes
find-implementation
hide-unmatched-rapid-hints
# colors
completion.fgcompletion.bg
completion.alternate-bg
completion.category.fgcompletion.category.bg
completion.category.border.top
completion.category.border.bottom
completion.item.selected.fgcompletion.item.selected.bg
completion.item.selected.border.top
completion.item.selected.border.bottom
completion.match.fg
completion.scrollbar.fgcompletion.scrollbar.bg
statusbar.fgstatusbar.bg
statusbar.fg.private
statusbar.bg.private
statusbar.fg.insert
statusbar.bg.insert
statusbar.fg.command
statusbar.bg.command
statusbar.fg.command.private
statusbar.bg.command.private
statusbar.fg.caret
statusbar.bg.caret
statusbar.fg.caret-selection
statusbar.bg.caret-selectionstatusbar.progress.bg
statusbar.url.fg
statusbar.url.fg.success
statusbar.url.fg.success.https
statusbar.url.fg.error
statusbar.url.fg.warn
statusbar.url.fg.hover
tabs.fg.odd
tabs.bg.odd
tabs.fg.even
tabs.bg.even
tabs.fg.selected.odd
tabs.bg.selected.odd
tabs.fg.selected.even
tabs.bg.selected.even
tabs.bg.bar
tabs.indicator.start
tabs.indicator.stop
tabs.indicator.error
tabs.indicator.system
hints.fghints.bg
hints.fg.match
downloads.bg.bar
downloads.fg.start
downloads.bg.start
downloads.fg.stop
downloads.bg.stop
downloads.fg.system
downloads.bg.system
downloads.fg.error
downloads.bg.errorwebpage.bg
keyhint.fg
keyhint.fg.suffixkeyhint.bg
messages.fg.error
messages.bg.error
messages.border.error
messages.fg.warning
messages.bg.warning
messages.border.warningmessages.fg.infomessages.bg.infomessages.border.info
prompts.fgprompts.bgprompts.selected.bg
# fonts
_monospace
completion
completion.category
tabbar
statusbar
downloads
hints
debug-console
web-family-standard
web-family-fixed
web-family-serif
web-family-sans-serif
web-family-cursive
web-family-fantasy
web-size-minimum
web-size-minimum-logical
web-size-default
web-size-default-fixed
keyhint
messages.error
messages.warningmessages.info
prompts
New
With the new config, there won't be any sections anymore, instead there
are dotted "paths" to settings. After a quick first look, they could look
something like this:
aliases
auto_search
confirm_quit
default_page
history_session_interval
ignore_case
new_instance_open_target
new_instance_open_target_window
url_incdec_segments
searchengines
session_default_name
start_page
yank_ignored_url_parameters
auto_save.config
auto_save.interval
auto_save.session
colors.completion.alternate_bgcolors.completion.bgcolors.completion.category.bg
colors.completion.category.border.bottom
colors.completion.category.border.top
colors.completion.category.fg
colors.completion.fgcolors.completion.item.selected.bg
colors.completion.item.selected.border.bottom
colors.completion.item.selected.border.top
colors.completion.item.selected.fg
colors.completion.match.fgcolors.completion.scrollbar.bg
colors.completion.scrollbar.fg
colors.downloads.bg.bar
colors.downloads.bg.error
colors.downloads.bg.start
colors.downloads.bg.stop
colors.downloads.bg.system
colors.downloads.fg.error
colors.downloads.fg.start
colors.downloads.fg.stop
colors.downloads.fg.systemcolors.hints.bg
colors.hints.fg
colors.hints.match.fgcolors.keyhint.bg
colors.keyhint.fg
colors.keyhint.suffix.fg
colors.messages.bg.errorcolors.messages.bg.info
colors.messages.bg.warning
colors.messages.border.errorcolors.messages.border.info
colors.messages.border.warning
colors.messages.fg.errorcolors.messages.fg.info
colors.messages.fg.warningcolors.prompts.bg
colors.prompts.fgcolors.prompts.selected.bg
colors.statusbar.bg.caret
colors.statusbar.bg.caret_selection
colors.statusbar.bg.command
colors.statusbar.bg.command_private
colors.statusbar.bg.insert
colors.statusbar.bg.normal
colors.statusbar.bg.private
colors.statusbar.fg.caret
colors.statusbar.fg.caret_selection
colors.statusbar.fg.command
colors.statusbar.fg.command_private
colors.statusbar.fg.insert
colors.statusbar.fg.normal
colors.statusbar.fg.privatecolors.statusbar.progress.bg
colors.statusbar.url.fg
colors.statusbar.url.fg.error
colors.statusbar.url.fg.hover
colors.statusbar.url.fg.warn
colors.statusbar.url.success.http.fgcolors.statusbar.url.success.https.bg
colors.tabs.bg.bar
colors.tabs.bg.even
colors.tabs.bg.odd
colors.tabs.bg.selected.even
colors.tabs.bg.selected.odd
colors.tabs.fg.even
colors.tabs.fg.odd
colors.tabs.fg.selected.even
colors.tabs.fg.selected.odd
colors.tabs.indicator.error
colors.tabs.indicator.start
colors.tabs.indicator.stop
colors.tabs.indicator.systemcolors.webpage.bg
completion.cmd_history_max_items
completion.height
completion.quick
completion.scrollbar.padding
completion.scrollbar.width
completion.show
completion.shrink
completion.timestamp_format
completion.web_history_max_items
content.accept_language
content.cache_size
content.cookies.accept
content.custom_headers
content.default_encoding
content.developer_extras
content.dns_prefetch
content.do_not_track
content.frame_flattening
content.geolocation
content.host_blocking.enabled
content.host_blocking.lists
content.host_blocking.whitelist
content.hyperlink_auditing
content.images
content.javascript
content.javascript.alert
content.javascript.can_access_clipboard
content.javascript.can_close_windows
content.javascript.can_open_windows_automatically
content.javascript.log
content.javascript.modal_dialog
content.javascript.prompt
content.local_content_can_access_file_urls
content.local_content_can_access_remote_urls
content.local_storage
content.maximum_pages_in_cache
content.media_capture
content.netrc_file
content.notifications
content.offline_web_application_cache
content.pdfjs
content.plugins
content.print_element_backgrounds
content.private_browsing
content.proxy
content.proxy_dns_requests
content.referer_header
content.ssl_strict
content.user_agent
content.user_stylesheet
content.webgl
content.xss_auditing
cookies.cookies.store
downloads.location.directory
downloads.location.prompt
downloads.location.remember
downloads.open_dispatcher
downloads.path_suggestion
downloads.position
downloads.remove_finished
editor.command
editor.encoding
fonts.completion.category
fonts.completion.entry
fonts.debug_console
fonts.downloads
fonts.hints
fonts.keyhint
fonts.messages.errorfonts.messages.info
fonts.messages.warning
fonts.monospace
fonts.prompts
fonts.statusbar
fonts.tabbar
fonts.web.family.cursive
fonts.web.family.fantasy
fonts.web.family.fixed
fonts.web.family.sans_serif
fonts.web.family.serif
fonts.web.family.standard
fonts.web.size.default
fonts.web.size.default_fixed
fonts.web.size.minimum
fonts.web.size.minimum_logical
hints.auto_follow
hints.auto_follow_timeout
hints.border
hints.chars
hints.dictionary
hints.find_implementation
hints.hide_unmatched_rapid_hints
hints.min_chars
hints.mode
hints.next_regexes
hints.prev_regexes
hints.scatter
hints.uppercase
input.ambiguous_timeout
input.forward_unbound_keys
input.insert_mode.auto_focused
input.insert_mode.auto_leave
input.insert_mode.plugins
input.links_included_in_focus_chain
input.partial_timeout
input.rocker_gestures
input.spatial_navigation
keyhint.blacklist
keyhint.delay
messages.timeout
messages.unfocused
prompt.filebrowser
prompt.radius
scrolling.bar
scrolling.smooth
statusbar.position
statusbar.hide
statusbar.padding
tabs.background
tabs.close_mouse_button
tabs.favicons.scale
tabs.favicons.show
tabs.indicator_padding
tabs.last_close
tabs.mousewheel_switching
tabs.movable
tabs.new_position
tabs.new_position_explicit
tabs.padding
tabs.position
tabs.select_on_remove
tabs.show
tabs.show_switching_delay
tabs.tabs_are_windows
tabs.title.alignment
tabs.title.format
tabs.title.format_pinned
tabs.width.bar
tabs.width.indicator
tabs.width.pinned
tabs.wrap
window.hide_wayland_decoration
window.title_format
zoom.default
zoom.levels
zoom.mouse_divider
zoom.text_only
I've tried to group related settings together, but there are still a few
oddballs at the top.
Compared with the previous sections, more stuff is in content (notably,
stuff which was in network or general before), ui is gone, and there are
some more fine-grained groups.
What do you think? What would you do differently? What setting name (or
possible values) have you always found confusing? I personally think
new_instance_open_target and tabs.new_position_explicit need a new name,
but I don't know what yet...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2708>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ATT4eVlNljxY_Hnm7ysEMx1jCuBbvnx2ks5sCSkegaJpZM4N1OJY>
.
|
Depending on how you will be doing the per-domain settings, we could copy weechat's style of having a inheritable default and a specific setting having their domain prepended:
|
@nishantjr I agree, good catch! I've changed things accordingly in 371c15a, see configdata.yml for the newest version. As for adding a hierarchy for the oddballs, I'll have to agree with @Ambrevar and others above - I don't think adding something like Anything else? Any ideas about what to do with |
Things I'd change:
I once again forgot what the "explicit" means in |
If I remember correctly, |
What @lahwaacz says sounds about right. If you check the behavior in Chromium, Ctrl-clicking a link opens a tab to the right of the current one ("not explicit", i.e. it's a "child" of the current tab), but doing ctrl-t opens a tab at the far right ("explicit", i.e. it's really a new unrelated tab). Maybe |
What about |
@NoctuaNivalis Thanks for the suggestions there, but I decided I actually don't like them (sorry! As for the I'll take another look at configdata.yml now, and look at it again later to make sure I didn't miss anything - but other than that, I consider this done. |
I also just updated the settings docs for the new config- might be nicer way to look at them |
I think I actually found a "group" for most of the oddball settings which doesn't feel completely arbitrary: For For I also moved This leaves us with |
That's arguable at best - for example, the |
Hm, yeah, you're right. It's definitely more of a stretch than I thought. I reversed that part. |
I did some more changes:
Pretty satisfied so far. Still open for feedback, though. |
With the current config revolution™ going on, it's a good time to rename all settings to be more consistent and clear, or do any other breaking changes. I'd like some input on that topic!
Current settings
For reference, here's how things look currently:
New
With the new config, there won't be any sections anymore, instead there are dotted "paths" to settings. After a quick first look, they could look something like this:
I've tried to group related settings together, but there are still a few oddballs at the top.
Compared with the previous sections, more stuff is in
content
(notably, stuff which was innetwork
orgeneral
before),ui
is gone, and there are some more fine-grained groups.What do you think? What would you do differently? What setting name (or possible values) have you always found confusing? I personally think
new_instance_open_target
andtabs.new_position_explicit
need a new name, but I don't know what yet...The text was updated successfully, but these errors were encountered: