New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hint groups/selectors configurable #2773

Closed
The-Compiler opened this Issue Jul 2, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@The-Compiler
Copy link
Collaborator

The-Compiler commented Jul 2, 2017

With the new config we have dictionaries in the config.

With that, we could make hint groups/selectors configurable. Currently those are hardcoded in webelem.py:

SELECTORS = {
    Group.all: ('a, area, textarea, select, input:not([type=hidden]), button, '
                'frame, iframe, link, [onclick], [onmousedown], [role=link], '
                '[role=option], [role=button], img'),
    Group.links: 'a[href], area[href], link[href], [role=link][href]',
    Group.images: 'img',
    Group.url: '[src], [href]',
    Group.inputs: ('input[type=text], input[type=email], input[type=url], '
                   'input[type=tel], input[type=number], '
                   'input[type=password], input[type=search], '
                   'input:not([type]), textarea'),
}

This would make it possible to add hints for custom elements (if it's a per-url setting), or add new groups like "media" to hint audio/video elements to be opened with mpv.

Also, :hint could take a selector instead of a group name too.

@CmdrSharp

This comment has been minimized.

Copy link

CmdrSharp commented Apr 5, 2018

Perhaps this could work sort of inverse of how Chrome highlights an element in the Chrome Inspector when highlighting markup? So in this case, you'd hover over an element on a site with your mouse, and have an option to make that element hinted.

@olmokramer olmokramer referenced this issue Apr 5, 2018

Merged

Add hints.selectors setting #3806

8 of 11 tasks complete
@The-Compiler

This comment has been minimized.

Copy link
Collaborator

The-Compiler commented Oct 8, 2018

@CmdrSharp Better late than never I guess... Something like that would be nice, but is probably too complex right now. #674 is somewhat similar FWIW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment