More sophisticated adblocking #29

Open
The-Compiler opened this Issue Oct 1, 2014 · 18 comments

Comments

Projects
None yet
7 participants
Collaborator

The-Compiler commented Oct 1, 2014

There should be an adblocker.

edit: A host-based adblocker which is sufficient for most cases is implemented since a long time already, this issue is still open because it could be improved by implementing ABP-like filterlist support.

The eric IDE helpviewer does have one (in Python), which might be a good inspiration

@The-Compiler The-Compiler self-assigned this Oct 1, 2014

This comment has been minimized.

Show comment Hide comment
@The-Compiler

The-Compiler Oct 2, 2014

Collaborator

Before we have a real blocker we could use http://www.floppymoose.com/ in the default user-stylesheet. We probably should check the license though.

Collaborator

The-Compiler commented Oct 2, 2014

Before we have a real blocker we could use http://www.floppymoose.com/ in the default user-stylesheet. We probably should check the license though.

This comment has been minimized.

Show comment Hide comment
@The-Compiler

The-Compiler Oct 2, 2014

Collaborator

https://github.com/foxhead128/nimbus also does adblocking which might be another inspiration

Collaborator

The-Compiler commented Oct 2, 2014

https://github.com/foxhead128/nimbus also does adblocking which might be another inspiration

This comment has been minimized.

Show comment Hide comment
@The-Compiler

The-Compiler Nov 13, 2014

Collaborator

We should implement basic adblocking by downloading hosts-files and merging them.

Sources:

Algorithm for parsing/merging/etc:

User interface:

  • Setting permissions->adblock-host-lists with a comma-separated list of URLs
  • Command :update-adblock which downloads all lists (see Qt example) and merges them
Collaborator

The-Compiler commented Nov 13, 2014

We should implement basic adblocking by downloading hosts-files and merging them.

Sources:

Algorithm for parsing/merging/etc:

User interface:

  • Setting permissions->adblock-host-lists with a comma-separated list of URLs
  • Command :update-adblock which downloads all lists (see Qt example) and merges them

This comment has been minimized.

Show comment Hide comment
@The-Compiler

The-Compiler Dec 3, 2014

Collaborator

host-file adblocking has been implemented in 0134646 - leaving this open for more sophisticated blocking

Collaborator

The-Compiler commented Dec 3, 2014

host-file adblocking has been implemented in 0134646 - leaving this open for more sophisticated blocking

This comment has been minimized.

Show comment Hide comment
@HalosGhost

HalosGhost Dec 15, 2014

Contributor

I would recommend µblock as a model to use. It aims to be much lighter and faster than ABP while actually extending some functionality.

Contributor

HalosGhost commented Dec 15, 2014

I would recommend µblock as a model to use. It aims to be much lighter and faster than ABP while actually extending some functionality.

@The-Compiler The-Compiler changed the title from Adblock to More sophisticated adblocking Oct 1, 2015

@The-Compiler The-Compiler removed their assignment Oct 1, 2015

This comment has been minimized.

Show comment Hide comment
@1-61803

1-61803 Apr 6, 2017

Is there any ad-blocking implementation as of now, internal or via plugin?

1-61803 commented Apr 6, 2017

Is there any ad-blocking implementation as of now, internal or via plugin?

This comment has been minimized.

Show comment Hide comment
@parchd-1

parchd-1 Apr 6, 2017

Yes, there is host-file adblocking, as you can see above.
The plugin system isn't done yet, so other adblock systems aren't either. You can also see that in the issue linked to above ;).

parchd-1 commented Apr 6, 2017

Yes, there is host-file adblocking, as you can see above.
The plugin system isn't done yet, so other adblock systems aren't either. You can also see that in the issue linked to above ;).

This comment has been minimized.

Show comment Hide comment
@1-61803

1-61803 Apr 6, 2017

@parchd-1 I skimmed. I see the hosts file implementation from 2014 and #30 has adblock stroke through. What is the actual state of development of plugins that would allow better ad blocking but also plugins like ublock and greasemonkey?

1-61803 commented Apr 6, 2017

@parchd-1 I skimmed. I see the hosts file implementation from 2014 and #30 has adblock stroke through. What is the actual state of development of plugins that would allow better ad blocking but also plugins like ublock and greasemonkey?

This comment has been minimized.

Show comment Hide comment
@The-Compiler

The-Compiler Apr 7, 2017

Collaborator

What is the actual state of development of plugins

There isn't anything other than the thoughts listed in #30 so far.

that would allow better ad blocking but also plugins like ublock

What from ublock are you missing, other than having adblockplus-like block lists?

and greasemonkey

Something similar to it should be possible with per-domain settings (#27) which is the current main focus - in around a week I'll launch qutebrowser's second crowdfunding, to work on this (and maybe start some work on plugins if there's time left) during my summer holidays. Subscribe to that issue if you want to get notified once it's up!

Collaborator

The-Compiler commented Apr 7, 2017

What is the actual state of development of plugins

There isn't anything other than the thoughts listed in #30 so far.

that would allow better ad blocking but also plugins like ublock

What from ublock are you missing, other than having adblockplus-like block lists?

and greasemonkey

Something similar to it should be possible with per-domain settings (#27) which is the current main focus - in around a week I'll launch qutebrowser's second crowdfunding, to work on this (and maybe start some work on plugins if there's time left) during my summer holidays. Subscribe to that issue if you want to get notified once it's up!

This comment has been minimized.

Show comment Hide comment
@1-61803

1-61803 Apr 7, 2017

What from ublock are you missing, other than having adblockplus-like block lists?

I just have switched to ublock as ABP caused high CPU usage. Having the same lists makes rendering sites equally across hosts. Just a first impression after switching blocker.

I still have to make it work in my main older machine on 10.8. I encountered the same problem pointed out here. It should compile from source, it's python and qt, right?

Something similar to it should be possible with per-domain settings (#27) which is the current main focus - in around a week I'll launch qutebrowser's second crowdfunding

Subscribed. What's the best way to get regular (weekly but not daily) news? If I compile it in my 10.8 I'll be certainly donating to your project.

1-61803 commented Apr 7, 2017

What from ublock are you missing, other than having adblockplus-like block lists?

I just have switched to ublock as ABP caused high CPU usage. Having the same lists makes rendering sites equally across hosts. Just a first impression after switching blocker.

I still have to make it work in my main older machine on 10.8. I encountered the same problem pointed out here. It should compile from source, it's python and qt, right?

Something similar to it should be possible with per-domain settings (#27) which is the current main focus - in around a week I'll launch qutebrowser's second crowdfunding

Subscribed. What's the best way to get regular (weekly but not daily) news? If I compile it in my 10.8 I'll be certainly donating to your project.

This comment has been minimized.

Show comment Hide comment
@The-Compiler

The-Compiler Apr 7, 2017

Collaborator

I still have to make it work in my main older machine on 10.8. I encountered the same problem pointed out here. It should compile from source, it's python and qt, right?

There's nothing in qutebrowser itself you'll need to compile, as it's Python. You'll need a working Python with PyQt though. If you can get a Python 3.5 or 3.6 installed (maybe via Homebrew or pyenv), you should be able to do something like pip install PyQt5 qutebrowser (optionally in a virtualenv). If you need help, open a separate issue though, please.

What's the best way to get regular (weekly but not daily) news?

There isn't anything like a regular newsletter. You can look at the changelog and github activity manually though.

I'd also recommend subscribing to the qutebrowser-announce mailinglist where important announcements like new releases are posted.

Collaborator

The-Compiler commented Apr 7, 2017

I still have to make it work in my main older machine on 10.8. I encountered the same problem pointed out here. It should compile from source, it's python and qt, right?

There's nothing in qutebrowser itself you'll need to compile, as it's Python. You'll need a working Python with PyQt though. If you can get a Python 3.5 or 3.6 installed (maybe via Homebrew or pyenv), you should be able to do something like pip install PyQt5 qutebrowser (optionally in a virtualenv). If you need help, open a separate issue though, please.

What's the best way to get regular (weekly but not daily) news?

There isn't anything like a regular newsletter. You can look at the changelog and github activity manually though.

I'd also recommend subscribing to the qutebrowser-announce mailinglist where important announcements like new releases are posted.

This comment has been minimized.

Show comment Hide comment
@asmbits

asmbits Feb 26, 2018

Is there any progress? It is the only reason I haven't switched to qutebrowser yet. I cannot imagine seeing ads while browsing google, youtube or any other site.

asmbits commented Feb 26, 2018

Is there any progress? It is the only reason I haven't switched to qutebrowser yet. I cannot imagine seeing ads while browsing google, youtube or any other site.

This comment has been minimized.

Show comment Hide comment
@The-Compiler

The-Compiler Feb 27, 2018

Collaborator

@asmbits I don't think anyone is working on this currently, as the current adblocker is working well enough overall and there are lots and lots of other more important issues 😉

Collaborator

The-Compiler commented Feb 27, 2018

@asmbits I don't think anyone is working on this currently, as the current adblocker is working well enough overall and there are lots and lots of other more important issues 😉

This comment has been minimized.

Show comment Hide comment
@sagb

sagb Feb 27, 2018

On the sites where ads come not from standard CDNs the current adblock is useless. This major bug is very annoying.

sagb commented Feb 27, 2018

On the sites where ads come not from standard CDNs the current adblock is useless. This major bug is very annoying.

This comment has been minimized.

Show comment Hide comment
@The-Compiler

The-Compiler Feb 27, 2018

Collaborator

You seem to have an... interesting understanding of what "major bug" means. I'd be glad if someone picked this up, but it won't be me in the near future, I have lots of other stuff on my plate. Are you volunteering? 😉

Collaborator

The-Compiler commented Feb 27, 2018

You seem to have an... interesting understanding of what "major bug" means. I'd be glad if someone picked this up, but it won't be me in the near future, I have lots of other stuff on my plate. Are you volunteering? 😉

This comment has been minimized.

Show comment Hide comment
@sagb

sagb Feb 27, 2018

Sorry, it's beyond my skills and available time.

sagb commented Feb 27, 2018

Sorry, it's beyond my skills and available time.

This comment has been minimized.

Show comment Hide comment
@CosmoJG

CosmoJG Mar 22, 2018

@The-Compiler Would it be alright if myself or someone else tried directly integrating some of uBlock's code? Or would you rather have something built from scratch?

I think direct integration would do wonders for preventing the classic open-source effort-reduplication problem.

CosmoJG commented Mar 22, 2018

@The-Compiler Would it be alright if myself or someone else tried directly integrating some of uBlock's code? Or would you rather have something built from scratch?

I think direct integration would do wonders for preventing the classic open-source effort-reduplication problem.

This comment has been minimized.

Show comment Hide comment
@The-Compiler

The-Compiler Mar 22, 2018

Collaborator

@CosmoJG I don't see how that'd be possible (as no WebExtension API exists), so the point is moot 😉

Collaborator

The-Compiler commented Mar 22, 2018

@CosmoJG I don't see how that'd be possible (as no WebExtension API exists), so the point is moot 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment