Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Python 3.8 #4928

Closed
The-Compiler opened this issue Jul 23, 2019 · 12 comments
Closed

Issues with Python 3.8 #4928

The-Compiler opened this issue Jul 23, 2019 · 12 comments
Labels
priority: 0 - high

Comments

@The-Compiler
Copy link
Member

The-Compiler commented Jul 23, 2019

Python 3.8 is scheduled for 2019-10-21.

Time to check what it breaks!

@The-Compiler The-Compiler added the priority: 1 - middle label Jul 23, 2019
@The-Compiler

This comment has been minimized.

@The-Compiler

This comment has been minimized.

@The-Compiler

This comment has been minimized.

@The-Compiler

This comment has been minimized.

@The-Compiler

This comment has been minimized.

@The-Compiler The-Compiler added priority: 0 - high and removed priority: 1 - middle labels Jul 23, 2019
@The-Compiler

This comment has been minimized.

@The-Compiler

This comment has been minimized.

@The-Compiler

This comment has been minimized.

@The-Compiler

This comment has been minimized.

The-Compiler added a commit that referenced this issue Aug 17, 2019
The-Compiler added a commit that referenced this issue Aug 18, 2019
This also fixes some calls to utils.KeySequence with a string.

See #4928
The-Compiler added a commit that referenced this issue Aug 18, 2019
The-Compiler added a commit that referenced this issue Aug 18, 2019
@The-Compiler
Copy link
Member Author

The-Compiler commented Aug 18, 2019

Got most issues with our code fixed in the py38 branch (likely going to merge it tomorrow).

As for pytest-bdd: pytest-dev/pytest-bdd#316

The-Compiler added a commit that referenced this issue Aug 18, 2019
The-Compiler added a commit that referenced this issue Aug 18, 2019
@The-Compiler
Copy link
Member Author

The-Compiler commented Oct 21, 2019

All up and running now, and Travis is running with Python 3.8!

@The-Compiler
Copy link
Member Author

The-Compiler commented Nov 16, 2019

Some of the issues in #5013 (comment) are probably due to Python 3.8 as well.

The-Compiler added a commit that referenced this issue Nov 19, 2019
The-Compiler added a commit that referenced this issue Nov 20, 2020
  qutebrowser/mainwindow/tabwidget.py:645: DeprecationWarning: an
  integer is required (got type float).  Implicit conversion to integers
  using __int__ is deprecated, and may be removed in a future version of
  Python.
    size = QSize(width, height)

This was a left-over from 66ab7f2.

See #4928
The-Compiler added a commit that referenced this issue Nov 20, 2020
  qutebrowser/mainwindow/tabwidget.py:645: DeprecationWarning: an
  integer is required (got type float).  Implicit conversion to integers
  using __int__ is deprecated, and may be removed in a future version of
  Python.
    size = QSize(width, height)

This was a left-over from 66ab7f2.

See #4928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 0 - high
Projects
None yet
Development

No branches or pull requests

1 participant