Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Spell checking #700
Spell checking #700
Comments
|
This is something which isn't normally doable using the QtWebKit APIs - however, there's the QupZilla/qtwebkit-plugins repo, which can be used to build a After that's copied to Someone would have to look into more integration like QupZilla has (i.e. a right-click menu), but that's very low-priority for me. |
|
Quick follow-up - my train was going over the border before, so I was a bit in a hurry to send the comment before my connection was gone I don't know whether the kind of integration QupZilla has with the plugin would be possible with the PyQt APIs, it might not be possible at all. It seems the plugin does multi-language, at least in the right-click menu in QupZilla you get checkboxes for languages. Also, all that probably won't work when I add a QtWebEngine/Chromium backend to qutebrowser - I don't know what the plans are to add a spellcheck API there, or if it works out-of-the-box already. Of course, pull requests regarding this would be welcome (and thanks for all the great other PRs!), but probably #349 (a custom context menu) would have to be done first. |
|
FWIW I now packaged |
|
I've installed the package and still don't see any highlighting of misspelled words. Is there some configuration necessary? |
|
It should just work™. Someone else reported it didn't work for them in IRC as well, but I have no idea why... When trying to reproduce I had some issues as well, but then I figured out it sometimes just takes a few seconds after typing a misspelled word until it gets highlighted. If it doesn't work with e.g. Otter Browser either (the situation is different for QupZilla as that has a more sophisticated spell checking integrated), I'd suggest opening a bug at https://github.com/QupZilla/qtwebkit-plugins/issues FWIW there's QupZilla/qtwebkit-plugins#7 already open, but as said, it works fine for me... |
|
Otter Browser seems to have custom spell-checking, which also does not work for me. They have still some issues (OtterBrowser/otter-browser#504 (comment)) and installing qtwebkit-plugins did not make any difference. |
|
Can you see any |
|
We (me and |
|
It doesn't seem to work for me either; I have Arch Linux with that AUR package installed, as well as hunspell-en. |
|
Same here doesn't work for me on Arch with the AUR package installed. I have |
|
Do you see something interesting when you run |
|
Yeah: |
|
Okay - the |
|
If I remember correctly, you have some custom Qt builds for testing? The |
|
I can only find that symbol in |
|
On Sat, 04 Jun 2016 08:35:44 -0700, Florian Bruhin notifications@github.com wrote:
QWebSpellChecker is just an interface (class with only pure virtual methods). I currentl can't check myself because I have no QtWebKit (not even Qt) installed |
From
If I'm reading this correctly, the symbol is only used in the file, but not defined. Comparing with qupzilla's built-in spell-checker: so the symbol is correctly defined there. What does it look like on your side, @The-Compiler? By the way, the so the missing symbol is |
|
The most notable difference between qtwebkit-plugins-git and qupzilla-qtwebkit-git PKGBUILDs is the There are differences between the |
|
I'd really expect |
|
Sorry - missed the comment above. It seems indeed for me the symbols are defined there, not just referenced: And yeah, I'm using |
By default, yes. But in Arch, qmake is a symlink to qtchooser, which is configurable (see |
|
Any luck on this? :) |
|
@raelgc On what exactly? |
|
Make the highlighting of misspelled words works in qt5 using the QupZilla/qtwebkit-plugins. I have the same problem on ScudCloud, but don't know how to solve it. |
|
I don't either, as it works fine for me |
|
I ran into this same For NixOS in sed -i "s,plugin.h,plugin.h ${qtwebkit.dev}/include/QtWebKit/qwebkitplatformplugin.h," src/src.pro |
|
Maybe @nowrep can tell us more about whether this sounds like a good fix or not |
|
QtWebEngine 5.8 is supposed to support "Spellchecking with Hunspell" - any chance to enable it in qutebrowser? |
|
Here's a basic example to use the WebEngine 5.8 API: diff --git i/qutebrowser/browser/webengine/webenginesettings.py w/qutebrowser/browser/webengine/webenginesettings.py
index b029b4fd5..7aa208c70 100644
--- i/qutebrowser/browser/webengine/webenginesettings.py
+++ w/qutebrowser/browser/webengine/webenginesettings.py
@@ -278,6 +278,10 @@ MAPPINGS = {
'ui': {
'smooth-scrolling':
Attribute(QWebEngineSettings.ScrollAnimatorEnabled),
+ 'spell': ProfileSetter(getter='spellCheckEnabled',
+ setter='setSpellCheckEnabled'),
+ 'spell-languages': ProfileSetter(getter='spellCheckLanguages',
+ setter='setSpellCheckLanguages'),
},
'storage': {
'local-storage':
diff --git i/qutebrowser/browser/webkit/webkitsettings.py w/qutebrowser/browser/webkit/webkitsettings.py
index caeef296f..c251ad5a0 100644
--- i/qutebrowser/browser/webkit/webkitsettings.py
+++ w/qutebrowser/browser/webkit/webkitsettings.py
@@ -230,6 +230,11 @@ MAPPINGS = {
# Attribute(QWebSettings.AcceleratedCompositingEnabled),
#'tiled-backing-store':
# Attribute(QWebSettings.TiledBackingStoreEnabled),
+ # TODO: Give error; would be confusing otherwise.
+ # 'spell': ProfileSetter(getter='spellCheckEnabled',
+ # setter='setSpellCheckEnabled'),
+ # 'spell-languages': ProfileSetter(getter='spellCheckLanguages',
+ # setter='setSpellCheckLanguages'),
},
'storage': {
'offline-storage-database':
diff --git i/qutebrowser/config/configdata.py w/qutebrowser/config/configdata.py
index 1fbc22937..38f1a3ef2 100644
--- i/qutebrowser/config/configdata.py
+++ w/qutebrowser/config/configdata.py
@@ -418,6 +418,17 @@ def data(readonly=False):
SettingValue(typ.Bool(), 'true'),
"Show a filebrowser in upload/download prompts."),
+ # qwebengine_convert_dict /usr/share/hunspell/en_US.dic en_US.bdic
+ # https://doc.qt.io/qt-5/qml-qtwebengine-webengineprofile.html#spellCheckEnabled-prop
+ # http://doc.qt.io/qt-5/qtwebengine-webenginewidgets-spellchecker-example.html
+ ('spell',
+ SettingValue(typ.Bool(), 'true'),
+ "Enable spell checking; only works on QtWebEngine."),
+
+ ('spell-languages',
+ SettingValue(typ.List(typ.String(), none_ok=True), 'en_US'),
+ "Spell checking language; only works on QtWebEngine."),
+
readonly=readonly
)),Since it uses its own dictionary format, you'll need to convert it from the Hunspell ones: Qutebrowser should do this automatically, or we should provide some repository with those compiled files at least for common languages. I'm not going to work on this for now, as there are other thing I'd prefer to do first, but anyone is free to take the above code and run with it :-) Related links: |
|
Thanks for getting the ball rolling, @Carpetsmoker! As for "making sure that QtWebKit users get a friendly error": Simply don't use it in |
|
Hey, so I was thinking of pushing this thing forward. What do you think should be the proper way of handling dictionary conversion? An internal command, like "install-dict", that looks for dictionaries in hunspell directory? Where should we store the .bdic files? |
|
First of all: Note that I won't have the time to review any contributions until September because I'm busy with exams, and I'll also merge the new-config branch then - so if you work on something now, you might need to rebase it and solve conflicts then. I'm not really sure what's feasible here. The best way would indeed be to have some command to convert dictionaries, but it's probably non-trivial to do that in Python (see QtWebEngine's tool). Maybe we could just read Chromium's dicts which (on Linux) are in |
|
About the review, that's totally fine, I'm quite busy myself so probably it will take me some time anyway. I just noticed this thing has been hanging here for a long time, so it's about time someone made it happen. Enabling spell check is straightforward enough, it's the dictionaries that are the issue. I'll spend some time figuring out how to best approach it, and will get back to you. |
|
I just opened QTBUG-62236 FWIW - I think QtWebEngine should handle this by loading Chromium's dictionaries. Also, at least according to the docs the current paths where dictionaries are searched are very cumbersome, at least for typical system-wide qutebrowser/Qt installations on Linux... FWIW I did a quick test and could get spell-checking to work in QtWebEngine with >>> profile = QWebEngineProfile.defaultProfile()
>>> profile.setSpellCheckEnabled(True)
>>> profile.setSpellCheckLanguages(["en-US-7-1"])Not sure what the This is all less than optimal, but I guess the best we can do right now is to add an option to set the languages (or even figure them out by ourselves), and document what to do to get things working (create that symlink on Linux, not sure about macOS and Windows). |
|
I know you will already have considered this, but I'll put it on the record: not everyone who would like to use spell-checking has or wants Chromium installed. |
|
Sure - you could still always download Hunspell dictionaries, merge them using QtWebEngine's convert_dict tool, and use that. But using Chromium's dictionaries would be a nice way to make it work "automatically". |
|
True. Apparently (just been poking about) the dictionaries can also be found here, so just grabbing a single dictionary is also possible. |
|
Ah, nice! This is before Chromium switched to git though. I think this page is the most up-to-date source for them. |
|
I thought the dates seemed a bit too old! |
|
So I couldn't resist and submitted a change to Qt adding a Hopefully will made it into Qt 5.10. |
|
That's a good catch with dictionaries in the repository. I think it makes the most sense to use these. I can work on a command installing it locally this weekend. Do you guys think we should maintain a list of possible languages to install? (then one could choose one from the list if not sure what the name is) |
|
A qutebrowser command for it won't work, as the dictionaries need to be in a location like However, a standalone commandline script would be very nice. It'd ideally get the file list from the repository (dunno if there's an API for the file list - the links at the bottom right get the commit only, or maybe using the GitHub mirror and API). Then it could offer a list of dictionaries to download, and download them to the right location. With Qt 5.10, we can then revisit this and implement some logic to read Chromium's dictionaries if available. |
|
(sorry, I used a different account for the post above by accident) |
|
Quick update: Qt 5.10 will have a |
|
It's not exactly ready yet, but mostly working. I created a pull request in case someone has some time to take a look. I'll get back to it next or the following weekend. |
I often use spell checking in my browser.
It should support multiple languages, but I would prefer that it's not like
dwbwhere you see both languages intermixed. This is very annoying if you use 3 languages.