Spell checking

[arp242]

I often use spell checking in my browser.

It should support multiple languages, but I would prefer that it's not like dwb where you see both languages intermixed. This is very annoying if you use 3 languages.

[The-Compiler]

This is something which isn't normally doable using the QtWebKit APIs - however, there's the QupZilla/qtwebkit-plugins repo, which can be used to build a libqtwebkitplugins.so.

After that's copied to /usr/lib/qt/plugins/webkit (at least here on Arch) I at least get underlined words in text fields.

Someone would have to look into more integration like QupZilla has (i.e. a right-click menu), but that's very low-priority for me.

[The-Compiler]

Quick follow-up - my train was going over the border before, so I was a bit in a hurry to send the comment before my connection was gone 😆

I don't know whether the kind of integration QupZilla has with the plugin would be possible with the PyQt APIs, it might not be possible at all.

It seems the plugin does multi-language, at least in the right-click menu in QupZilla you get checkboxes for languages.

Also, all that probably won't work when I add a QtWebEngine/Chromium backend to qutebrowser - I don't know what the plans are to add a spellcheck API there, or if it works out-of-the-box already.

Of course, pull requests regarding this would be welcome (and thanks for all the great other PRs!), but probably #349 (a custom context menu) would have to be done first.

[The-Compiler]

FWIW I now packaged qtwebkit-plugins in the Archlinux AUR: https://aur.archlinux.org/packages/qtwebkit-plugins-git/

[lahwaacz]

I've installed the package and still don't see any highlighting of misspelled words. Is there some configuration necessary?

[The-Compiler]

It should just work™. Someone else reported it didn't work for them in IRC as well, but I have no idea why...

When trying to reproduce I had some issues as well, but then I figured out it sometimes just takes a few seconds after typing a misspelled word until it gets highlighted.

If it doesn't work with e.g. Otter Browser either (the situation is different for QupZilla as that has a more sophisticated spell checking integrated), I'd suggest opening a bug at https://github.com/QupZilla/qtwebkit-plugins/issues

FWIW there's QupZilla/qtwebkit-plugins#7 already open, but as said, it works fine for me...

[lahwaacz]

Otter Browser seems to have custom spell-checking, which also does not work for me. They have still some issues (OtterBrowser/otter-browser#504 (comment)) and installing qtwebkit-plugins did not make any difference.

[The-Compiler]

Can you see any SpellCheck output when you start with --debug? Do you have a dictionary like hunspell-en (on Arch) installed?

[lahwaacz]

We (me and grep) don't see any output related to spell-checking. Both hunspell and hunspell-en are installed.

[ids1024]

It doesn't seem to work for me either; I have Arch Linux with that AUR package installed, as well as hunspell-en.

[shioyama]

Same here doesn't work for me on Arch with the AUR package installed. I have hunspell-en installed.

[The-Compiler]

Do you see something interesting when you run QT_DEBUG_PLUGINS=1 qutebrowser --temp-basedir --debug --logfilter qt? For me it's this:

16:18:08 WARNING  qt         Unknown module:none:0 Found metadata in lib /usr/lib/qt/plugins/webkit/libqtwebkitplugins.so, metadata=
{
    "IID": "org.qtwebkit.QtWebKit.QtWebKitPlugin",
    "MetaData": {
    },
    "className": "QtWebKitPlugin",
    "debug": false,
    "version": 329216
}
16:18:08 DEBUG    qt         Unknown module:none:0 loaded library "/usr/lib/qt/plugins/webkit/libqtwebkitplugins.so"

[lahwaacz]

Yeah:

16:35:32 WARNING  qt         Unknown module:none:0 Found metadata in lib /usr/lib/qt/plugins/webkit/libqtwebkitplugins.so, metadata=
{
    "IID": "org.qtwebkit.QtWebKit.QtWebKitPlugin",
    "MetaData": {
    },
    "className": "QtWebKitPlugin",
    "debug": false,
    "version": 329216
}


  File "/usr/bin/qutebrowser", line 9, in <module>
    load_entry_point('qutebrowser==0.6.2', 'gui_scripts', 'qutebrowser')()
  File "/usr/lib/python3.5/site-packages/qutebrowser/qutebrowser.py", line 159, in main
    return app.run(args)
  File "/usr/lib/python3.5/site-packages/qutebrowser/app.py", line 111, in run
    ret = qt_mainloop()
  File "/usr/lib/python3.5/site-packages/qutebrowser/app.py", line 121, in qt_mainloop
    return qApp.exec_()
  File "/usr/lib/python3.5/site-packages/qutebrowser/utils/log.py", line 356, in qt_message_handler
    stack = ''.join(traceback.format_stack())

16:35:32 DEBUG    qt         Unknown module:none:0 loaded library "/usr/lib/qt/plugins/webkit/libqtwebkitplugins.so"
  File "/usr/bin/qutebrowser", line 9, in <module>
    load_entry_point('qutebrowser==0.6.2', 'gui_scripts', 'qutebrowser')()
  File "/usr/lib/python3.5/site-packages/qutebrowser/qutebrowser.py", line 159, in main
    return app.run(args)
  File "/usr/lib/python3.5/site-packages/qutebrowser/app.py", line 111, in run
    ret = qt_mainloop()
  File "/usr/lib/python3.5/site-packages/qutebrowser/app.py", line 121, in qt_mainloop
    return qApp.exec_()
  File "/usr/lib/python3.5/site-packages/qutebrowser/utils/log.py", line 356, in qt_message_handler
    stack = ''.join(traceback.format_stack())

16:35:32 WARNING  qt         Unknown module:none:0 QLibraryPrivate::loadPlugin failed on "/usr/lib/qt/plugins/webkit/libqtwebkitplugins.so" : "Cannot load library /usr/lib/qt/plugins/webkit/libqtwebkitplugins.so: (/usr/lib/qt/plugins/webkit/libqtwebkitplugins.so: undefined symbol: _ZTI16QWebSpellChecker)"
  File "/usr/bin/qutebrowser", line 9, in <module>
    load_entry_point('qutebrowser==0.6.2', 'gui_scripts', 'qutebrowser')()
  File "/usr/lib/python3.5/site-packages/qutebrowser/qutebrowser.py", line 159, in main
    return app.run(args)
  File "/usr/lib/python3.5/site-packages/qutebrowser/app.py", line 111, in run
    ret = qt_mainloop()
  File "/usr/lib/python3.5/site-packages/qutebrowser/app.py", line 121, in qt_mainloop
    return qApp.exec_()
  File "/usr/lib/python3.5/site-packages/qutebrowser/utils/log.py", line 356, in qt_message_handler
    stack = ''.join(traceback.format_stack())

[The-Compiler]

Okay - the QLibraryPrivate::loadPlugin failed on "/usr/lib/qt/plugins/webkit/libqtwebkitplugins.so" : "Cannot load library /usr/lib/qt/plugins/webkit/libqtwebkitplugins.so: (/usr/lib/qt/plugins/webkit/libqtwebkitplugins.so: undefined symbol: _ZTI16QWebSpellChecker)" tells us what's going on, now I only have to find out why... 😉

[lahwaacz]

If I remember correctly, you have some custom Qt builds for testing? The _ZTI16QWebSpellChecker symbol might be missing only in the Arch packages, or there is some missing (optional) dependency. You could try to find out which file contains the symbol 😉