Join GitHub today
Switch browsing history away from QWebHistoryInterface and add titles. #1350
Changes history items to be added when initialLayoutCompleted is fired as opposed to when navigation is initiated. Regarding #1345 this method saves the final url after redirects and doesn't save the url of the redirect.
There are some things I am unsure about:
Here is some comparisons with dwb and otter:
Otter (for the qtwebkit backend at least) calls handleHistory() at a few
dwb and QupZilla use load finished. They only save the final page on
This method, the old method, dwb and otter all save the requested url to
I added the call to setDefaultInterface back and that works. Though with the whole not saving redirects thing sites, like search engine result pages, that link via redirectors don't show their links as visited. Maybe it would be best to save both urls clicked on and pages visited. Bit more noise in the history file but that isn't an issue. Just need to control for duplicates...